You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Mike Sokolov (JIRA)" <ji...@apache.org> on 2019/07/14 00:34:00 UTC
[jira] [Commented] (SOLR-13629) Remove whitespace only lines &
trailing whitespace from analytics package
[ https://issues.apache.org/jira/browse/SOLR-13629?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16884528#comment-16884528 ]
Mike Sokolov commented on SOLR-13629:
-------------------------------------
We don't want to remove all the blank (or whitespace-only) lines; many of them are there to help with readability. Glancing at the patch it looks like you did not remove blank lines, just trailiing white space, so that's good, but if that's the intent, you should update the issue description.
> Remove whitespace only lines & trailing whitespace from analytics package
> -------------------------------------------------------------------------
>
> Key: SOLR-13629
> URL: https://issues.apache.org/jira/browse/SOLR-13629
> Project: Solr
> Issue Type: Task
> Security Level: Public(Default Security Level. Issues are Public)
> Affects Versions: 8.1.1
> Reporter: Neal Sidhwaney
> Priority: Trivial
> Attachments: SOLR-13629.patch
>
>
> I"m making some changes to analytics and noticed that the guidelines ask to create separate patches for formatting/whitespace changes. This issue is meant for the patch to remove whitespace only lines as well as trailing whitespace from lines.
--
This message was sent by Atlassian JIRA
(v7.6.14#76016)
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org