You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2015/07/14 21:43:21 UTC
[GitHub] incubator-brooklyn pull request: Update BrooklynNode default expan...
GitHub user neykov opened a pull request:
https://github.com/apache/incubator-brooklyn/pull/745
Update BrooklynNode default expand folder
The expand folder name changed to brooklyn-dist-<version>.
Also check the healthy status instead of the root URL so we know the instance has warmed up and is ready to service requests.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/incubator-brooklyn fix/brooklyn-node
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-brooklyn/pull/745.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #745
----
commit 363ea3fa79fa9b26b3acdb7b81a9443b59bd8054
Author: Svetoslav Neykov <sv...@cloudsoftcorp.com>
Date: 2015-07-14T19:40:55Z
Update BrooklynNode default expand folder
The expand folder name changed to brooklyn-dist-<version>. Also check the healthy status instead of the root URL so we know the instance has warmed up and is ready to service requests.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Update BrooklynNode default expan...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/incubator-brooklyn/pull/745
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Update BrooklynNode default expan...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on the pull request:
https://github.com/apache/incubator-brooklyn/pull/745#issuecomment-124335052
@neykov One question about something inside a comment. Won't let that hold up merging this now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Update BrooklynNode default expan...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/745#discussion_r35413929
--- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNodeSshDriver.java ---
@@ -127,8 +127,8 @@ public void install() {
String uploadUrl = entity.getConfig(BrooklynNode.DISTRO_UPLOAD_URL);
// Need to explicitly give file, because for snapshot URLs you don't get a clean filename from the URL.
- // This filename is used to generate the first URL to try:
- // file://$HOME/.brooklyn/repository/BrooklynNode/0.6.0-SNAPSHOT/brooklyn-0.6.0-SNAPSHOT-dist.tar.gz
+ // This filename is used to generate the first URL to try: [BROOKLYN_VERSION_BELOW]
+ // file://$HOME/.brooklyn/repository/BrooklynNode/0.8.0-SNAPSHOT/brooklynnode-0.8.0-snapshot.tar.gz
--- End diff --
Yes, the filename is lowercase (I copied the URL from stdin). See https://github.com/apache/incubator-brooklyn/blob/master/core/src/main/java/brooklyn/entity/drivers/downloads/DownloadProducerFromLocalRepo.java#L51.
Good point about `BROOKLYN_VERSION_BELOW`, the lower case part won't get replaced, so I think best is to just remove the marker and leave the version as is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-brooklyn pull request: Update BrooklynNode default expan...
Posted by aledsage <gi...@git.apache.org>.
Github user aledsage commented on a diff in the pull request:
https://github.com/apache/incubator-brooklyn/pull/745#discussion_r35396241
--- Diff: software/base/src/main/java/brooklyn/entity/brooklynnode/BrooklynNodeSshDriver.java ---
@@ -127,8 +127,8 @@ public void install() {
String uploadUrl = entity.getConfig(BrooklynNode.DISTRO_UPLOAD_URL);
// Need to explicitly give file, because for snapshot URLs you don't get a clean filename from the URL.
- // This filename is used to generate the first URL to try:
- // file://$HOME/.brooklyn/repository/BrooklynNode/0.6.0-SNAPSHOT/brooklyn-0.6.0-SNAPSHOT-dist.tar.gz
+ // This filename is used to generate the first URL to try: [BROOKLYN_VERSION_BELOW]
+ // file://$HOME/.brooklyn/repository/BrooklynNode/0.8.0-SNAPSHOT/brooklynnode-0.8.0-snapshot.tar.gz
--- End diff --
Are we using lower-case "snapshot" in the filename? Should we use "brooklynnode-0.8.0-SNAPSHOT.tar.gz" instead (for consistency, even if it is a bit ugly)? What will BROOKLYN_VERSION_BELOW do with the lower-case snapshot?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---