[GitHub] sunjincheng121 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API

[GitBox <gi...@apache.org>]

sunjincheng121 commented on a change in pull request #7209: [FLINK-10977][table] Add UnBounded FlatAggregate operator to streaming Table API
URL: https://github.com/apache/flink/pull/7209#discussion_r244905640
 
 

 ##########
 File path: flink-libraries/flink-table/src/main/scala/org/apache/flink/table/api/table.scala
 ##########
 @@ -367,6 +367,38 @@ class Table(
     groupBy(fieldsExpr: _*)
   }
 
+  /**
+    * Perform a global flatAggregate without groupBy. FlatAggregate takes a TableAggregateFunction
+    * which returns multiple rows. Use a selection after the flatAggregate.
+    *
+    * Example:
+    *
+    * {{{
+    *   val tableAggFunc: TableAggregateFunction = new MyTableAggregateFunction
+    *   tab.flatAggregate(tableAggFunc('a, 'b)).select('_1, '_2, '_3)
+    * }}}
+    */
+  def flatAggregate(tableAggCall: TableAggFunctionCall): FlatAggTable = {
 
 Review comment:
   User can not be create a `TableAggFunction Call` , In table API user always using String and Expression for the parameter. So I suggest using `TableAggFunctionCall` -> `Expression`. And we can do some check logic. What do you think?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services