You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Amareshwari Sriramadasu <am...@apache.org> on 2016/05/06 12:38:16 UTC
Review Request 47066: LENS-1033 : Fix HQLParser to honor double
spaces in literals
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47066/
-----------------------------------------------------------
Review request for lens.
Bugs: LENS-1033
https://issues.apache.org/jira/browse/LENS-1033
Repository: lens
Description
-------
Fix HQLParser to honor double spaces in literals
Diffs
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d00188
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fcf975e
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java b89ed2c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java a223449
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionContext.java 64ada27
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b
lens-cube/src/test/java/org/apache/lens/cube/parse/join/TestBridgeTableJoinCtx.java 06b9509
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa7491
Diff: https://reviews.apache.org/r/47066/diff/
Testing
-------
Tests in lens-cube and lens-driver-jdbc passed. Running full suite.
Thanks,
Amareshwari Sriramadasu
Re: Review Request 47066: LENS-1033 : Fix HQLParser to honor double
spaces in literals
Posted by Rajat Khandelwal <ra...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47066/#review132019
-----------------------------------------------------------
Ship it!
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java (line 397)
<https://reviews.apache.org/r/47066/#comment196063>
Looks like the comment is wrong. it should be `and > or`
- Rajat Khandelwal
On May 6, 2016, 6:08 p.m., Amareshwari Sriramadasu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/47066/
> -----------------------------------------------------------
>
> (Updated May 6, 2016, 6:08 p.m.)
>
>
> Review request for lens.
>
>
> Bugs: LENS-1033
> https://issues.apache.org/jira/browse/LENS-1033
>
>
> Repository: lens
>
>
> Description
> -------
>
> Fix HQLParser to honor double spaces in literals
>
>
> Diffs
> -----
>
> lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d00188
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fcf975e
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java b89ed2c
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java a223449
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionContext.java 64ada27
> lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b
> lens-cube/src/test/java/org/apache/lens/cube/parse/join/TestBridgeTableJoinCtx.java 06b9509
> lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa7491
>
> Diff: https://reviews.apache.org/r/47066/diff/
>
>
> Testing
> -------
>
> Tests in lens-cube and lens-driver-jdbc passed. Running full suite.
>
>
> Thanks,
>
> Amareshwari Sriramadasu
>
>
Re: Review Request 47066: LENS-1033 : Fix HQLParser to honor double
spaces in literals
Posted by Amareshwari Sriramadasu <am...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/47066/
-----------------------------------------------------------
(Updated May 6, 2016, 12:55 p.m.)
Review request for lens.
Changes
-------
Updated comment in the test
Bugs: LENS-1033
https://issues.apache.org/jira/browse/LENS-1033
Repository: lens
Description
-------
Fix HQLParser to honor double spaces in literals
Diffs (updated)
-----
lens-cube/src/main/java/org/apache/lens/cube/parse/HQLParser.java 0d00188
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBaseCubeQueries.java fcf975e
lens-cube/src/test/java/org/apache/lens/cube/parse/TestBridgeTableQueries.java b89ed2c
lens-cube/src/test/java/org/apache/lens/cube/parse/TestCubeRewriter.java a223449
lens-cube/src/test/java/org/apache/lens/cube/parse/TestExpressionContext.java 64ada27
lens-cube/src/test/java/org/apache/lens/cube/parse/TestHQLParser.java 590d81b
lens-cube/src/test/java/org/apache/lens/cube/parse/join/TestBridgeTableJoinCtx.java 06b9509
lens-driver-jdbc/src/test/java/org/apache/lens/driver/jdbc/TestColumnarSQLRewriter.java 1aa7491
Diff: https://reviews.apache.org/r/47066/diff/
Testing
-------
Tests in lens-cube and lens-driver-jdbc passed. Running full suite.
Thanks,
Amareshwari Sriramadasu