You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/13 22:48:24 UTC
[GitHub] [airflow] dstandish opened a new pull request #13050: airflow should use same JSONEncoder as flask
dstandish opened a new pull request #13050:
URL: https://github.com/apache/airflow/pull/13050
closes: https://github.com/apache/airflow/issues/13046
When library `simplejson` is used, flask uses it. But our AirflowJSONEncoder class _always_ subclasses `json.JSONEncoder`. We can resolve this by using whatever version flask is using.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744088928
I think no need now. The bot (like most bots) is a bit stupid - does not really know too much about the code ;), so the main assumption is - if it touches anything about the "core" part, it should run all the tests - but in this case is more to the commuters who can (as humans do ;) ) think if this is a good solution or not. I am about to go to sleep now - so likely to go back to it tomorrow - but maybe other humans will make good decisions here in the meantime
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish edited a comment on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
dstandish edited a comment on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744086704
maybe it makes sense to leave dag serialization json always with `json`, assuming it doesn't have any interactions with flask.
however i did notice its location and naming (`from airflow.settings import json`) make it seem "global", i.e. not just for dag serde, which could lead to confusion. maybe makes sense to rename e.g. `dag_serde_json` or something so it's clear it's for specific subset of uses... but this is above my pay grade :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish edited a comment on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
dstandish edited a comment on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744086704
maybe it makes sense to leave dag serialization always with `json`, assuming it doesn't have any interactions with flask.
however, given its location and naming (`from airflow.settings import json`), which makes it seem "global", it perhaps could lead to confusion. e.g. could be named as `dag_serde_json` or something... but this is above my pay grade :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish edited a comment on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
dstandish edited a comment on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744087905
@potiuk should i rebase this ? bot is telling me to... i assume this is to make it run the skipped tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744273117
sorry :(
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] github-actions[bot] commented on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744086800
The PR most likely needs to run full matrix of tests because it modifies parts of the core of Airflow. However, committers might decide to merge it quickly and take the risk. If they don't merge it quickly - please rebase it to the latest master at your convenience, or amend the last commit of the PR, and push it with --force-with-lease.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk edited a comment on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
potiuk edited a comment on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744088928
I think no need now. The bot (like most bots) is a bit stupid - does not really know too much about the code ;), so the main assumption is - if it touches anything about the "core" part, it should run all the tests - but in this case is more to the committers who can (as humans do ;) ) think if this is a good solution or not. I am about to go to sleep now - so likely to go back to it tomorrow - but maybe other humans will make good decisions here in the meantime
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744087905
@potiuk should i rebase this ? bot is telling me too... i assume this is to make it run the skipped tests?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744246532
the 3 failing tests look flakey (exit code 137), if someone can retrigger
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish removed a comment on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
dstandish removed a comment on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744086704
maybe it makes sense to leave dag serialization json always with `json`, assuming it doesn't have any interactions with flask.
however i did notice its location and naming (`from airflow.settings import json`) make it seem "global", i.e. not just for dag serde, which could lead to confusion. maybe makes sense to rename e.g. `dag_serde_json` or something so it's clear it's for specific subset of uses... but this is above my pay grade :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb commented on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
ashb commented on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744085138
We've got a configurable JSON module used in the dag serialiser - we're should look at if we want to unify these
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] dstandish commented on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
dstandish commented on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744086704
maybe it makes sense to leave serialization always with `json`, assuming it doesn't have any interactions with flask.
however, given its location and naming (`from airflow.settings import json`), which makes it seem "global", it perhaps could lead to confusion. e.g. could be named as `dag_serde_json` or something... but this is above my pay grade :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] ashb merged pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
ashb merged pull request #13050:
URL: https://github.com/apache/airflow/pull/13050
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #13050: airflow should use same JSONEncoder as flask
Posted by GitBox <gi...@apache.org>.
potiuk commented on pull request #13050:
URL: https://github.com/apache/airflow/pull/13050#issuecomment-744269141
Yeah we have those 3 tests failing now all the time, so retriggering will not help :(. I will take a closer look today at it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org