You are viewing a plain text version of this content. The canonical link for it is here.
Posted to pr@jena.apache.org by GitBox <gi...@apache.org> on 2021/03/05 13:20:58 UTC
[GitHub] [jena] afs opened a new pull request #948: jena-jdbc maintainence
afs opened a new pull request #948:
URL: https://github.com/apache/jena/pull/948
Fix warnings:
* In tests, add `@SuppressWarnings("resource")` to classes.
* In main, rewrite to use try-with-resource (one case is not possible).
* Replace `c.newInstance()` with `c.getDeclaredConstructor().newInstance()`
Add `src/test/resources/log4j.properties` files.
Remove `AbstractJenaDriverTests.river_connect_bad_06` which now does not pass and no longer seems to test a feature.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse merged pull request #948: jena-jdbc maintenance
Posted by GitBox <gi...@apache.org>.
rvesse merged pull request #948:
URL: https://github.com/apache/jena/pull/948
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] rvesse commented on pull request #948: jena-jdbc maintenance
Posted by GitBox <gi...@apache.org>.
rvesse commented on pull request #948:
URL: https://github.com/apache/jena/pull/948#issuecomment-792708491
@afs Thanks for catching that, weirdly that test was still passing locally
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on a change in pull request #948: jena-jdbc maintainence
Posted by GitBox <gi...@apache.org>.
afs commented on a change in pull request #948:
URL: https://github.com/apache/jena/pull/948#discussion_r588291333
##########
File path: jena-core/src/main/java/org/apache/jena/irix/IRIProviderAny.java
##########
@@ -21,7 +21,7 @@
import java.util.Objects;
/**
- * Non-resolving provider that accepts anything string for <...>
+ * Non-resolving provider that accepts anything string for <...>.
Review comment:
Unrelated to jena-jdbc - another javadoc issue that checking the build showed up.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #948: jena-jdbc maintenance
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #948:
URL: https://github.com/apache/jena/pull/948#issuecomment-792690624
@rvesse - nice that the CVE warning has gone away.
OK to merge this post-fix cleanup now?
"CTR" still exists - review can be async.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org
[GitHub] [jena] afs commented on pull request #948: jena-jdbc maintenance
Posted by GitBox <gi...@apache.org>.
afs commented on pull request #948:
URL: https://github.com/apache/jena/pull/948#issuecomment-792731230
I don't doubt it - likewise, I've had cases where "old" code has been used. Seems to be SNAPSHOT related.
And not just in Eclipse.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: pr-unsubscribe@jena.apache.org
For additional commands, e-mail: pr-help@jena.apache.org