You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2018/11/29 08:35:57 UTC
[GitHub] dottorblaster commented on a change in pull request #1769: Add
Credo to Elixir test suite
dottorblaster commented on a change in pull request #1769: Add Credo to Elixir test suite
URL: https://github.com/apache/couchdb/pull/1769#discussion_r237391573
##########
File path: Makefile
##########
@@ -172,14 +172,18 @@ soak-eunit: couch
while [ $$? -eq 0 ] ; do $(REBAR) -r eunit $(EUNIT_OPTS) ; done
.PHONY: elixir
-elixir: elixir-check-formatted
+elixir: elixir-check-formatted elixir-credo
@rm -rf dev/lib
@dev/run -a adm:pass --no-eval test/elixir/run
.PHONY: elixir-check-formatted
elixir-check-formatted:
@cd test/elixir/ && mix format --check-formatted
+.PHONY: elixir-credo
+elixir-credo:
+ @cd test/elixir/ && mix deps.get && mix credo
+
Review comment:
@wohali Credo doesn't format code at all, and I know we are using `mix format`'s check for that 🙂
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services