[GitHub] [cloudstack] andrijapanicsb commented on issue #3383: [WIP DO NOT MERGE] template: copy md5 mismatch

[GitBox <gi...@apache.org>]

andrijapanicsb commented on issue #3383: [WIP DO NOT MERGE] template: copy md5 mismatch
URL: https://github.com/apache/cloudstack/pull/3383#issuecomment-562105795
 
 
   As discussed (internally) this fix simply set the source image md5sum to NULL (instead of reading a wrong md5sum from DB, from the compressed file) and thus when SSVM receives the files in the new zone, since no source MD5 sum was defined, it will not check and will consider an image as downloaded successfully - which should be fine in 99% of cases.
   
   I would like to test a silly thing - if the download of template (via the SSVM in the destination zone) is somehow interrupted - do we ever reach the MD5 "to check or not to check" part of code - ideally the download process should break and no false positive in sense of "successful" download.
   
   This can be tested while copying a template from zone1 to zone2, by logging in to zone1 SSVM and simply stopping the Apache webserver - simulating connection drop - and checking/confirm that on the destination zone the template download has broken as exected.
   
   @weizhouapache ping for opinion pls CC @rhtyd 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services