You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/05/30 16:31:36 UTC
[GitHub] [dolphinscheduler] WangJPLeo opened a new pull request, #10307: [Feature][Permission] Reconstruction of permissions of resource center and monitoring center.
WangJPLeo opened a new pull request, #10307:
URL: https://github.com/apache/dolphinscheduler/pull/10307
<!--Thanks very much for contributing to Apache DolphinScheduler. Please review https://dolphinscheduler.apache.org/en-us/community/development/pull-request.html before opening a pull request.-->
## Purpose of the pull request
Abstract functions, resource permission verification, and reconstruction of project management, security center, data source center, data quality, resource center and monitoring center module permission management.
## Brief change log
close #10306
## Verify this pull request
Manually verified the change by testing locally.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] Leijingwen commented on pull request #10307: [Feature][Permission] Reconstruction of permissions of resource center and monitoring center.
Posted by GitBox <gi...@apache.org>.
Leijingwen commented on PR #10307:
URL: https://github.com/apache/dolphinscheduler/pull/10307#issuecomment-1263139866
Why is the code written disabled？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] lenboo merged pull request #10307: [Feature][Permission] Reconstruction of permissions of resource center and monitoring center.
Posted by GitBox <gi...@apache.org>.
lenboo merged PR #10307:
URL: https://github.com/apache/dolphinscheduler/pull/10307
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] user-GitHub-user commented on a diff in pull request #10307: [Feature][Permission] Reconstruction of permissions of resource center and monitoring center.
Posted by GitBox <gi...@apache.org>.
user-GitHub-user commented on code in PR #10307:
URL: https://github.com/apache/dolphinscheduler/pull/10307#discussion_r909154502
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ResourceMapper.xml:
##########
@@ -60,17 +60,12 @@
</include>
,u.user_name
from t_ds_resources d,t_ds_user u
- where d.type=#{type} and d.pid=#{id} and d.user_id=u.id
- <if test="userId != 0">
- and (
- d.user_id=#{userId}
- <if test="resIds != null and resIds.size() > 0">
- or d.id in
- <foreach collection="resIds" item="i" open="(" close=")" separator=",">
- #{i}
- </foreach>
- </if>
- )
+ where d.type=#{type} and d.pid=#{id} and u.id = #{userId}
Review Comment:
why no need d.user_id = u.id ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] sonarcloud[bot] commented on pull request #10307: [Feature][Permission] Reconstruction of permissions of resource center and monitoring center.
Posted by GitBox <gi...@apache.org>.
sonarcloud[bot] commented on PR #10307:
URL: https://github.com/apache/dolphinscheduler/pull/10307#issuecomment-1141358859
Kudos, SonarCloud Quality Gate passed! [](https://sonarcloud.io/dashboard?id=apache-dolphinscheduler&pullRequest=10307)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10307&resolved=false&types=BUG) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10307&resolved=false&types=BUG) [0 Bugs](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10307&resolved=false&types=BUG)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10307&resolved=false&types=VULNERABILITY) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10307&resolved=false&types=VULNERABILITY) [0 Vulnerabilities](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10307&resolved=false&types=VULNERABILITY)
[](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10307&resolved=false&types=SECURITY_HOTSPOT) [](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10307&resolved=false&types=SECURITY_HOTSPOT) [0 Security Hotspots](https://sonarcloud.io/project/security_hotspots?id=apache-dolphinscheduler&pullRequest=10307&resolved=false&types=SECURITY_HOTSPOT)
[](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10307&resolved=false&types=CODE_SMELL) [](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10307&resolved=false&types=CODE_SMELL) [25 Code Smells](https://sonarcloud.io/project/issues?id=apache-dolphinscheduler&pullRequest=10307&resolved=false&types=CODE_SMELL)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10307&metric=new_coverage&view=list) [56.5% Coverage](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10307&metric=new_coverage&view=list)
[](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10307&metric=new_duplicated_lines_density&view=list) [1.2% Duplication](https://sonarcloud.io/component_measures?id=apache-dolphinscheduler&pullRequest=10307&metric=new_duplicated_lines_density&view=list)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [dolphinscheduler] lenboo commented on a diff in pull request #10307: [Feature][Permission] Reconstruction of permissions of resource center and monitoring center.
Posted by GitBox <gi...@apache.org>.
lenboo commented on code in PR #10307:
URL: https://github.com/apache/dolphinscheduler/pull/10307#discussion_r885117964
##########
dolphinscheduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/UdfFuncMapper.xml:
##########
@@ -62,11 +62,17 @@
<if test="searchVal!= null and searchVal != ''">
and udf.func_name like concat('%', #{searchVal}, '%')
</if>
- <if test="userId != 0">
- and udf.id in (
- select udf_id from t_ds_relation_udfs_user where user_id=#{userId}
- union select id as udf_id from t_ds_udfs where user_id=#{userId})
+ <if test="ids != null and ids.size() > 0">
+ and udf.id in
+ <foreach collection="ids" item="i" open="(" close=")" separator=",">
+ #{i}
+ </foreach>
</if>
+<!-- <if test="userId != 0">-->
Review Comment:
We can delete the unused code. Maybe you can fix it later
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org