You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2021/09/18 08:39:06 UTC

[GitHub] [pulsar] congbobo184 commented on a change in pull request #11905: Fixed KCA Sink handling of Json and Avro; support for kafka connectors that overload task.preCommit() directly

congbobo184 commented on a change in pull request #11905:
URL: https://github.com/apache/pulsar/pull/11905#discussion_r711558908



##########
File path: pulsar-io/kafka-connect-adaptor/src/test/java/org/apache/pulsar/io/kafka/connect/KafkaConnectSinkTest.java
##########
@@ -257,6 +265,8 @@ private void recordSchemaTest(Object value, Schema schema, Object expectedKey, S
                 .failFunction(status::decrementAndGet)
                 .build();
 
+        org.apache.kafka.connect.data.Schema kafkaSchema = PulsarSchemaToKafkaSchema.getKafkaConnectSchema(schema);

Review comment:
       This doesn't seem to be used




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org