You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/04/08 06:54:04 UTC
[GitHub] [incubator-shardingsphere] wqzwh opened a new pull request #5103:
Rewrite Vue charts code
wqzwh opened a new pull request #5103: Rewrite Vue charts code
URL: https://github.com/apache/incubator-shardingsphere/pull/5103
Fixes #5089
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #5103: Rewrite Vue charts code
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5103: Rewrite Vue charts code
URL: https://github.com/apache/incubator-shardingsphere/pull/5103#discussion_r405381255
##########
File path: shardingsphere-ui/shardingsphere-ui-frontend/package.json
##########
@@ -21,8 +21,8 @@
"lodash": "^4.17.11",
"moment": "^2.24.0",
"normalize.css": "^8.0.1",
+ "resize-detector": "^0.2.1",
Review comment:
What is this lib? can you add notice for that?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wqzwh commented on a change in pull
request #5103: Rewrite Vue charts code
Posted by GitBox <gi...@apache.org>.
wqzwh commented on a change in pull request #5103: Rewrite Vue charts code
URL: https://github.com/apache/incubator-shardingsphere/pull/5103#discussion_r405389139
##########
File path: shardingsphere-ui/shardingsphere-ui-frontend/src/components/ChartBase/index.vue
##########
@@ -0,0 +1,304 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License") you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+<template>
+ <div class="echarts"></div>
+</template>
+
+<script>
+import echarts from 'echarts'
+import debounce from 'lodash/debounce'
+import { addListener, removeListener } from 'resize-detector'
+import Vue from 'vue'
+
Review comment:
This is a secondary development, which is not completely consistent with the official code
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wqzwh commented on a change in pull
request #5103: Rewrite Vue charts code
Posted by GitBox <gi...@apache.org>.
wqzwh commented on a change in pull request #5103: Rewrite Vue charts code
URL: https://github.com/apache/incubator-shardingsphere/pull/5103#discussion_r405388797
##########
File path: shardingsphere-ui/shardingsphere-ui-frontend/package.json
##########
@@ -21,8 +21,8 @@
"lodash": "^4.17.11",
"moment": "^2.24.0",
"normalize.css": "^8.0.1",
+ "resize-detector": "^0.2.1",
Review comment:
This library is the one that the official Vue version of echarts relies on, so I also quoted
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wqzwh commented on issue #5103: Rewrite
Vue charts code
Posted by GitBox <gi...@apache.org>.
wqzwh commented on issue #5103: Rewrite Vue charts code
URL: https://github.com/apache/incubator-shardingsphere/pull/5103#issuecomment-610857051
> Why change backend notice if your code only change frontend?
The rebase operation is missing, resulting in duplicate commit
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] coveralls commented on issue #5103:
Rewrite Vue charts code
Posted by GitBox <gi...@apache.org>.
coveralls commented on issue #5103: Rewrite Vue charts code
URL: https://github.com/apache/incubator-shardingsphere/pull/5103#issuecomment-610841307
## Pull Request Test Coverage Report for [Build 10885](https://coveralls.io/builds/29932474)
* **0** of **0** changed or added relevant lines in **0** files are covered.
* No unchanged relevant lines lost coverage.
* Overall coverage remained the same at **57.23%**
---
| Totals | [](https://coveralls.io/builds/29932474) |
| :-- | --: |
| Change from base [Build 10875](https://coveralls.io/builds/29928055): | 0.0% |
| Covered Lines: | 11700 |
| Relevant Lines: | 20444 |
---
##### 💛 - [Coveralls](https://coveralls.io)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] wqzwh closed pull request #5103: Rewrite
Vue charts code
Posted by GitBox <gi...@apache.org>.
wqzwh closed pull request #5103: Rewrite Vue charts code
URL: https://github.com/apache/incubator-shardingsphere/pull/5103
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-shardingsphere] terrymanu commented on a change in pull
request #5103: Rewrite Vue charts code
Posted by GitBox <gi...@apache.org>.
terrymanu commented on a change in pull request #5103: Rewrite Vue charts code
URL: https://github.com/apache/incubator-shardingsphere/pull/5103#discussion_r405381543
##########
File path: shardingsphere-ui/shardingsphere-ui-frontend/src/components/ChartBase/index.vue
##########
@@ -0,0 +1,304 @@
+<!--
+ - Licensed to the Apache Software Foundation (ASF) under one or more
+ - contributor license agreements. See the NOTICE file distributed with
+ - this work for additional information regarding copyright ownership.
+ - The ASF licenses this file to You under the Apache License, Version 2.0
+ - (the "License") you may not use this file except in compliance with
+ - the License. You may obtain a copy of the License at
+ -
+ - http://www.apache.org/licenses/LICENSE-2.0
+ -
+ - Unless required by applicable law or agreed to in writing, software
+ - distributed under the License is distributed on an "AS IS" BASIS,
+ - WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ - See the License for the specific language governing permissions and
+ - limitations under the License.
+ -->
+
+<template>
+ <div class="echarts"></div>
+</template>
+
+<script>
+import echarts from 'echarts'
+import debounce from 'lodash/debounce'
+import { addListener, removeListener } from 'resize-detector'
+import Vue from 'vue'
+
Review comment:
Where is this file come from? Is it develop by ourself or copy from other project?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services