You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@zeppelin.apache.org by anthonycorbacho <gi...@git.apache.org> on 2016/12/02 07:20:13 UTC

[GitHub] zeppelin pull request #1720: Fix case where user use zeppelin in normal mode...

GitHub user anthonycorbacho opened a pull request:

    https://github.com/apache/zeppelin/pull/1720

    Fix case where user use zeppelin in normal mode with token

    ### What is this PR for?
    Fix the case where user use zeppelin in normal mode (doesnt use authentication) and set zeppelinhub token in zeppelin-env.sh.
    
    ### What type of PR is it?
    [Bug Fix | Hot Fix]
    
    ### Questions:
    * Does the licenses files need update? No
    * Is there breaking changes for older versions? No
    * Does this needs documentation? No
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/anthonycorbacho/incubator-zeppelin fix/ZeppelinhubNotebookRepo

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zeppelin/pull/1720.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1720
    
----
commit 7e5fbc5acb14a3dd8366b6f271fa7820b348f39b
Author: Anthony Corbacho <co...@gmail.com>
Date:   2016-12-02T07:18:17Z

    Fix case where user use zeppelin in normal mode with token

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1720: Fix case where user use zeppelin in normal mode with t...

Posted by khalidhuseynov <gi...@git.apache.org>.

Github user khalidhuseynov commented on the issue:

    https://github.com/apache/zeppelin/pull/1720
  
    I see two tests failing `testGetAllNotes`, `testGetNote` under the corresponding class test. Other than that looks good.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1720: Fix case where user use zeppelin in normal mode with t...

Posted by minahlee <gi...@git.apache.org>.

Github user minahlee commented on the issue:

    https://github.com/apache/zeppelin/pull/1720
  
    Tested, LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin issue #1720: Fix case where user use zeppelin in normal mode with t...

Posted by anthonycorbacho <gi...@git.apache.org>.

Github user anthonycorbacho commented on the issue:

    https://github.com/apache/zeppelin/pull/1720
  
    @minahlee @khalidhuseynov thanks you for review, fixed the test and hopefully merging it as a hotfix soon


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

[GitHub] zeppelin pull request #1720: Fix case where user use zeppelin in normal mode...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/zeppelin/pull/1720


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---