You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/09/18 08:33:00 UTC
[GitHub] [arrow] kszucs opened a new pull request #8218: [C++] Instrument AWS SDK cmake config to look for shared libraries
kszucs opened a new pull request #8218:
URL: https://github.com/apache/arrow/pull/8218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #8218:
URL: https://github.com/apache/arrow/pull/8218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#discussion_r491975226
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2697,6 +2703,10 @@ if(ARROW_S3)
sts)
endif()
+ if(DEFINED ENV{CONDA_PREFIX})
+ unset(BUILD_SHARED_LIBS)
Review comment:
You're unsetting it even if it was already set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on a change in pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
xhochy commented on a change in pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#discussion_r492031242
##########
File path: ci/conda_env_cpp.yml
##########
@@ -17,7 +17,7 @@
aws-sdk-cpp
benchmark=1.4.1
-boost-cpp>=1.68.0
Review comment:
The lower-limit is no problem, I'm more confused why/where we have an upper limit. This will cause issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8218: [C++] Instrument AWS SDK cmake config to look for shared libraries
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-694741448
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-696139780
Thank you @kszucs :-)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on a change in pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#discussion_r491975226
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2697,6 +2703,10 @@ if(ARROW_S3)
sts)
endif()
+ if(DEFINED ENV{CONDA_PREFIX})
+ unset(BUILD_SHARED_LIBS)
Review comment:
You're unsetting it even if it was already set.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-696099251
Well, it would be nice if this could be fixed in this PR, otherwise we can't be sure that the fix works on Windows.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#discussion_r491975704
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2697,6 +2703,10 @@ if(ARROW_S3)
sts)
endif()
+ if(DEFINED ENV{CONDA_PREFIX})
+ unset(BUILD_SHARED_LIBS)
Review comment:
I'm adding a flag for it then.
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2697,6 +2703,10 @@ if(ARROW_S3)
sts)
endif()
+ if(DEFINED ENV{CONDA_PREFIX})
+ unset(BUILD_SHARED_LIBS)
Review comment:
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#discussion_r491981851
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2697,6 +2703,10 @@ if(ARROW_S3)
sts)
endif()
+ if(DEFINED ENV{CONDA_PREFIX})
+ unset(BUILD_SHARED_LIBS)
Review comment:
Updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-696108884
```
CMake Error at C:/Miniconda37-x64/envs/arrow/Library/lib/cmake/Boost-1.74.0/BoostConfig.cmake:141 (find_package):
Found package configuration file:
C:/Miniconda37-x64/envs/arrow/Library/lib/cmake/boost_regex-1.74.0/boost_regex-config.cmake
but it set boost_regex_FOUND to FALSE so package "boost_regex" is
considered to be NOT FOUND. Reason given by package:
No suitable build variant has been found.
The following variants have been tried and rejected:
* boost_regex.lib (shared, Boost_USE_STATIC_LIBS=ON)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-696098116
Seems so, but that's a different issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-696098976
> Uh... was Boost upgraded in the meantime? There are compile errors on AppVeyor:
> https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/35318362/job/lhejm2nbvp1rdtid
As mentioned previously, the `boost-cpp[version='<1.70,>=1.68.0']` in AppVeyor is problematic. We build all Arrow dependencies currently with both 1.72 and 1.74, so both should work but not 1.68 or 1.69.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-694751058
https://issues.apache.org/jira/browse/ARROW-10037
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou closed pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
pitrou closed pull request #8218:
URL: https://github.com/apache/arrow/pull/8218
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
kszucs commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-696098116
Seems so, but that's a different issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] kszucs commented on a change in pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
kszucs commented on a change in pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#discussion_r491975704
##########
File path: cpp/cmake_modules/ThirdpartyToolchain.cmake
##########
@@ -2697,6 +2703,10 @@ if(ARROW_S3)
sts)
endif()
+ if(DEFINED ENV{CONDA_PREFIX})
+ unset(BUILD_SHARED_LIBS)
Review comment:
I'm adding a flag for it then.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on a change in pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
xhochy commented on a change in pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#discussion_r492031242
##########
File path: ci/conda_env_cpp.yml
##########
@@ -17,7 +17,7 @@
aws-sdk-cpp
benchmark=1.4.1
-boost-cpp>=1.68.0
Review comment:
The lower-limit is no problem, I'm more confused why/where we have an upper limit. This will cause issues.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-696096983
Uh... was Boost upgraded in the meantime? There are compile errors on AppVeyor:
https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/35318362/job/lhejm2nbvp1rdtid
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] removed a comment on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
github-actions[bot] removed a comment on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-694741448
<!--
Licensed to the Apache Software Foundation (ASF) under one
or more contributor license agreements. See the NOTICE file
distributed with this work for additional information
regarding copyright ownership. The ASF licenses this file
to you under the Apache License, Version 2.0 (the
"License"); you may not use this file except in compliance
with the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing,
software distributed under the License is distributed on an
"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
KIND, either express or implied. See the License for the
specific language governing permissions and limitations
under the License.
-->
Thanks for opening a pull request!
Could you open an issue for this pull request on JIRA?
https://issues.apache.org/jira/browse/ARROW
Then could you also rename pull request title in the following format?
ARROW-${JIRA_ID}: [${COMPONENT}] ${SUMMARY}
See also:
* [Other pull requests](https://github.com/apache/arrow/pulls/)
* [Contribution Guidelines - How to contribute patches](https://arrow.apache.org/docs/developers/contributing.html#how-to-contribute-patches)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-696098976
> Uh... was Boost upgraded in the meantime? There are compile errors on AppVeyor:
> https://ci.appveyor.com/project/ApacheSoftwareFoundation/arrow/builds/35318362/job/lhejm2nbvp1rdtid
As mentioned previously, the `boost-cpp[version='<1.70,>=1.68.0']` in AppVeyor is problematic. We build all Arrow dependencies currently with both 1.72 and 1.74, so both should work but not 1.68 or 1.69.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] pitrou commented on pull request #8218: ARROW-10037: [C++] Workaround to force find AWS SDK to look for shared libraries
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #8218:
URL: https://github.com/apache/arrow/pull/8218#issuecomment-696096983
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org