[PR] Fix JDBC connection lifecycle in GenericJdbcExecutor [wayang]

["harshitsingh070 (via GitHub)" <gi...@apache.org>]

harshitsingh070 opened a new pull request, #809:
URL: https://github.com/apache/wayang/pull/809

   ## Summary
   
   Restore the intended JDBC connection lifecycle in `GenericJdbcExecutor`.
   
   ## Root Cause
   
   `GenericJdbcExecutor` declared a JDBC `Connection`, but connection initialization was commented out. The commented code also used an outdated `createDatabaseDescriptor` signature.
   
   As a result, the executor's connection remained `null`, while the corresponding connection cleanup in `dispose()` was also commented out.
   
   ## Changes
   
   * Initialize the JDBC connection using the current `createDatabaseDescriptor` API.
   * Use the `genericjdbc` configuration namespace when creating the database descriptor.
   * Close the JDBC connection in `dispose()`.
   * Add regression tests covering connection creation and disposal.
   
   ## Testing
   
   Ran:
   
   ```text
   .\mvnw.cmd test -pl wayang-platforms/wayang-generic-jdbc -Pskip-prerequisite-check
   ```
   
   Result:
   
   ```text
   Tests run: 4
   Failures: 0
   Errors: 0
   Skipped: 0
   BUILD SUCCESS
   ```
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Fix JDBC connection lifecycle in GenericJdbcExecutor [wayang]

["zkaoudi (via GitHub)" <gi...@apache.org>]

zkaoudi merged PR #809:
URL: https://github.com/apache/wayang/pull/809


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@wayang.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org