You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Gergely Fürnstáhl (Code Review)" <ge...@cloudera.org> on 2022/09/12 12:59:19 UTC

[Impala-ASF-CR] IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG

Gergely Fürnstáhl has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18969


Change subject: IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG
......................................................................

IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG

Impala already supports said statement, added query tests for it.

Testing:
 - Generated parquet table with complex type by hive
 - Created hive and iceberg table from said file, provides same output
for describe statement

Change-Id: Ia363b913e101fd49b62a280721680f0eb88761c0
---
M testdata/data/README
A testdata/data/create_table_like_parquet_test.parquet
M tests/query_test/test_iceberg.py
3 files changed, 62 insertions(+), 2 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/69/18969/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia363b913e101fd49b62a280721680f0eb88761c0
Gerrit-Change-Number: 18969
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>

[Impala-ASF-CR] IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/18969 )

Change subject: IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG
......................................................................


Patch Set 2: Code-Review+2

Thanks for adding tests! LGTM!


-- 
To view, visit http://gerrit.cloudera.org:8080/18969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia363b913e101fd49b62a280721680f0eb88761c0
Gerrit-Change-Number: 18969
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 13:59:34 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18969 )

Change subject: IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG
......................................................................

IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG

Impala already supports said statement, added query tests for it.

Testing:
 - Generated parquet table with complex type by hive
 - Created hive and iceberg table from said file, provides same output
for describe statement

Change-Id: Ia363b913e101fd49b62a280721680f0eb88761c0
Reviewed-on: http://gerrit.cloudera.org:8080/18969
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M testdata/data/README
A testdata/data/create_table_like_parquet_test.parquet
M tests/query_test/test_iceberg.py
3 files changed, 62 insertions(+), 2 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia363b913e101fd49b62a280721680f0eb88761c0
Gerrit-Change-Number: 18969
Gerrit-PatchSet: 4
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18969 )

Change subject: IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG
......................................................................


Patch Set 2:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/11334/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/18969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia363b913e101fd49b62a280721680f0eb88761c0
Gerrit-Change-Number: 18969
Gerrit-PatchSet: 2
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 12 Sep 2022 13:20:23 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18969 )

Change subject: IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG
......................................................................


Patch Set 3: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia363b913e101fd49b62a280721680f0eb88761c0
Gerrit-Change-Number: 18969
Gerrit-PatchSet: 3
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 13:59:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18969 )

Change subject: IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG
......................................................................


Patch Set 3: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/18969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia363b913e101fd49b62a280721680f0eb88761c0
Gerrit-Change-Number: 18969
Gerrit-PatchSet: 3
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 19:08:10 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18969 )

Change subject: IMPALA-11438: Add tests for CREATE TABLE LIKE PARQUET STORED AS ICEBERG
......................................................................


Patch Set 3:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8581/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/18969
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia363b913e101fd49b62a280721680f0eb88761c0
Gerrit-Change-Number: 18969
Gerrit-PatchSet: 3
Gerrit-Owner: Gergely Fürnstáhl <gf...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Tamas Mate <tm...@apache.org>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Fri, 16 Sep 2022 13:59:59 +0000
Gerrit-HasComments: No