[jira] [Commented] (DATAFU-115) Make TupleFromBag implement Accumulator

["Matthew Hayes (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/DATAFU-115?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15187498#comment-15187498 ] 

Matthew Hayes commented on DATAFU-115:
--------------------------------------

The link to the review isn't viewable to me, probably because the DataFu group needs to be added.  However I looked at the patch and it seems fine to me.  Tests pass as well.

+1

> Make TupleFromBag implement Accumulator
> ---------------------------------------
>
>                 Key: DATAFU-115
>                 URL: https://issues.apache.org/jira/browse/DATAFU-115
>             Project: DataFu
>          Issue Type: Improvement
>    Affects Versions: 1.3.0
>            Reporter: Eyal Allweil
>            Priority: Minor
>              Labels: performance
>             Fix For: 1.3.1
>
>         Attachments: DATAFU-115.patch
>
>
> Similar to [DATAFU-114|https://issues.apache.org/jira/browse/DATAFU-114]. 
> TupleFromBag doesn't need to hold the bag in memory, and can iterate through it until it reaches the desired tuple. By implementing Accumulator, larger bags can be used and with a smaller memory footprint.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)