You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@spamassassin.apache.org by bu...@bugzilla.spamassassin.org on 2004/12/27 21:05:25 UTC

[Bug 4053] New: XMail v1.21 received header change

http://bugzilla.spamassassin.org/show_bug.cgi?id=4053

           Summary: XMail v1.21 received header change
           Product: Spamassassin
           Version: SVN Trunk (Latest Devel Version)
          Platform: All
        OS/Version: All
            Status: NEW
          Severity: enhancement
          Priority: P5
         Component: Libraries
        AssignedTo: dev@spamassassin.apache.org
        ReportedBy: jason@ellingson.com


Please see bug #3791 and note that the author of XMail has decided that 
beginning with XMail version 1.21, if an IP is in the received header, it will 
be enclosed in [square brackets].  The port (if displayed) will not be.

[123.45.67.89]
[123.45.67.89]:987



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4053] [review] XMail v1.21 received header change

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4053

spamassassin-contrib@msquadrat.de changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|XMail v1.21 received header |[review] XMail v1.21
                   |change                      |received header change
   Target Milestone|Future                      |3.0.3



------- Additional Comments From spamassassin-contrib@msquadrat.de  2004-12-30 17:10 -------
Rather trivial, but collecting some votes won't hurt... 



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4053] [review] XMail v1.21 received header change

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4053

jm@jmason.org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |needs 1 more vote





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4053] [review] XMail v1.21 received header change

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4053





------- Additional Comments From spamassassin-contrib@msquadrat.de  2005-01-03 12:24 -------
This *is* actually a new test case -- somebody committed the other one twice 
and forgot to increase the test counter so that test was run twice and the 
last one was skipped :) 



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4053] XMail v1.21 received header change

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4053





------- Additional Comments From jason@ellingson.com  2004-12-30 12:50 -------
It was sent out via eMail to everyone on the XMail mailing list.
=== BEGIN EMAIL ===
I made 1.21-pre02 with Windows binaries also:

http://www.xmailserver.org/xmail-1.21-pre02.tar.gz
http://www.xmailserver.org/xmail-1.21-pre02.win32bin.zip


Here's the change-log:

- Added external aliases support in the CTRL protocol.

- The MESSAGE.ID file is now automatically created, if missing.

- Changed the logic used to treat domain and user MAILPROC.TAB files. 
  Before, a user's MAILPROC.TAB was overriding the domain one, while now 
  the rules are merged together, with domain's ones first, followed by 
  user's ones.

- The maximum mailbox size of zero is now interpreted as unlimited.

- Fixed XMail's sendmail to detect non-RFC822 data and handle it 
  correctly.

- The IP:PORT addresses emission in spool files (and Received: lines) has 
  been changed to the form [IP]:PORT.

- Added filter logging, that is enabled with the new -Qg command line 
  option.

- Fixed an error message in the SMTP server, that was triggered by the 
  remote client not using the proper syntax for the "MAIL FROM:" and "RCPT TO:"
  commands.

- Fixed explicit routing through SMTPGW.TAB file.

- Fixed a possible problem with file locking that might be triggered from 
  CTRL commands cfgfileget/cfgfileset.

- Added a check to avoid the CTRL server to give an error when a domain 
  created with older versions of XMail does not have the domain directory 
  inside cmdaliases.

- The SMTP server FQDN variable should be set to the value 
of "SmtpServerDomain",
  when this is used inside the SERVER.TAB file.


Note that ATM only IN/OUT filters gets logged, whereas SMTP ones not.




- Davide

-
To unsubscribe from this list: send the line "unsubscribe xmail" in
the body of a message to ecartis@xmailserver.org
For general help: send the line "help" in the body of a message to
ecartis@xmailserver.org





------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4053] [review] XMail v1.21 received header change

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4053





------- Additional Comments From jm@jmason.org  2005-01-03 10:31 -------
+1

I'd prefer if the t script contained a new test-case for the "with brackets"
case, instead of replacing the old one, so that we know that both cases work
(not everyone will be upgrading their XMail servers at once!).  But that can be
fixed in trunk and this patch used for 3.0.x...



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4053] XMail v1.21 received header change

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4053





------- Additional Comments From spamassassin-contrib@msquadrat.de  2004-12-30 08:32 -------
Thanks for the report.  Could you add a link to the page/posting where that 
decision is explained (if such a age exists)?  I just wonder where they add 
the port (ie. if they potentially create invalid from tokens or if it affects 
only comments). 



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4053] XMail v1.21 received header change

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4053





------- Additional Comments From spamassassin-contrib@msquadrat.de  2004-12-30 17:06 -------
Created an attachment (id=2584)
 --> (http://bugzilla.spamassassin.org/attachment.cgi?id=2584&action=view)
patch against Received.pm

This patch is similar to the code I checked into trunk (r123754).  Some code
existed twice, blame copy-&-paste :)



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.

[Bug 4053] [review] XMail v1.21 received header change

Posted by bu...@bugzilla.spamassassin.org.
http://bugzilla.spamassassin.org/show_bug.cgi?id=4053





------- Additional Comments From jason@ellingson.com  2004-12-30 19:38 -------
Looks right to me.  Thanks for the quick work.  If I could vote, it'd be...

+1



------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.