You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by Peeyush Bishnoi <bp...@yahoo.co.in> on 2015/12/17 12:20:05 UTC
Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/
-----------------------------------------------------------
Review request for Falcon.
Bugs: FALCON-1661
https://issues.apache.org/jira/browse/FALCON-1661
Repository: falcon-git
Description
-------
Similar timestamp is getting added for Falcon instance vertex in GraphDB
Diffs
-----
common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
Diff: https://reviews.apache.org/r/41505/diff/
Testing
-------
yes
Thanks,
Peeyush Bishnoi
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Dec. 21, 2015, 10:26 a.m., Ajay Yadava wrote:
> > It seems that you are changing the same column to now contain nominal time, won't that be a backward incompatible change? I was thinking more on lines of adding nominal time also rather than changing the existing timestamp.
>
> Peeyush Bishnoi wrote:
> I don't think so that this is a backward incompatible change. Initially I have thought of adding nominal time as new property to vertex but on more closure look around test cases, I found that it should be nominal time for existing timestamp rather than actual time.
>
> Ajay Yadava wrote:
> Thanks for clarifying @Peeyush Bishnoi. From what you are telling it seems that's how it was intended to be but not implemented and hence a bug. Can you please point me to the relevant test cases which helped you reach the conclusion? I will also take a second look.
@ajay yadav. Please see the snippets in class MetadataMappingServiceTest, where time stamp is considered to be associated with nominaltime.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111450
-----------------------------------------------------------
On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Dec. 21, 2015, 10:26 a.m., Ajay Yadava wrote:
> > It seems that you are changing the same column to now contain nominal time, won't that be a backward incompatible change? I was thinking more on lines of adding nominal time also rather than changing the existing timestamp.
I don't think so that this is a backward incompatible change. Initially I have thought of adding nominal time as new property to vertex but on more closure look around test cases, I found that it should be nominal time for existing timestamp rather than actual time.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111450
-----------------------------------------------------------
On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Ajay Yadava <aj...@gmail.com>.
> On Dec. 21, 2015, 10:26 a.m., Ajay Yadava wrote:
> > It seems that you are changing the same column to now contain nominal time, won't that be a backward incompatible change? I was thinking more on lines of adding nominal time also rather than changing the existing timestamp.
>
> Peeyush Bishnoi wrote:
> I don't think so that this is a backward incompatible change. Initially I have thought of adding nominal time as new property to vertex but on more closure look around test cases, I found that it should be nominal time for existing timestamp rather than actual time.
Thanks for clarifying @Peeyush Bishnoi. From what you are telling it seems that's how it was intended to be but not implemented and hence a bug. Can you please point me to the relevant test cases which helped you reach the conclusion? I will also take a second look.
- Ajay
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111450
-----------------------------------------------------------
On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111450
-----------------------------------------------------------
It seems that you are changing the same column to now contain nominal time, won't that be a backward incompatible change? I was thinking more on lines of adding nominal time also rather than changing the existing timestamp.
- Ajay Yadava
On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Ying Zheng <yz...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111686
-----------------------------------------------------------
Ship it!
Ship It!
- Ying Zheng
On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Dec. 23, 2015, 10:30 a.m., Ajay Yadava wrote:
> > I had an offline discussion with Peeyush Bishnoi over this. Here is the summary of the discussion.
> >
> > 1. We can use vertex id as the unique parameter
> > 2. Although there is no direct API leveraging timestamp, there is a REXSTER api exposed using which anyone can query any property, so all properties are in a way public contract.
> > 3. Using same property for nominal time can lead to issues if users don't migrate incorrect data. e.g. if users query over a time range which has both incorrect data and correct data, users will get several incorrect results. Using a second property will return no such wrong results.
> > 4. If we decide to use the same property then it's fine but it will be helpful to call out the change explicitly so that users are aware.
> >
> > Peeyush wants to try some more approaches, will get back on this after that.
Approach used in the attached patch to use nominal time for two purpose. First it provide unique timestamp for each entity instance so that sorting the vertices done easily (as it required for issue FALCON-1643). Second, instance vertices for an entity is getting created with similar actual time (despite some vertices get create later) so it looks a bug and also I have seen that nominal time is getting used other places instead of actual time.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111769
-----------------------------------------------------------
On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Dec. 23, 2015, 10:30 a.m., Ajay Yadava wrote:
> > I had an offline discussion with Peeyush Bishnoi over this. Here is the summary of the discussion.
> >
> > 1. We can use vertex id as the unique parameter
> > 2. Although there is no direct API leveraging timestamp, there is a REXSTER api exposed using which anyone can query any property, so all properties are in a way public contract.
> > 3. Using same property for nominal time can lead to issues if users don't migrate incorrect data. e.g. if users query over a time range which has both incorrect data and correct data, users will get several incorrect results. Using a second property will return no such wrong results.
> > 4. If we decide to use the same property then it's fine but it will be helpful to call out the change explicitly so that users are aware.
> >
> > Peeyush wants to try some more approaches, will get back on this after that.
>
> Peeyush Bishnoi wrote:
> Approach used in the attached patch to use nominal time for two purpose. First it provide unique timestamp for each entity instance so that sorting the vertices done easily (as it required for issue FALCON-1643). Second, instance vertices for an entity is getting created with similar actual time (despite some vertices get create later) so it looks a bug and also I have seen that nominal time is getting used other places instead of actual time.
>
> Peeyush Bishnoi wrote:
> Also I tried to use the timestamp in FALCON-1643, as timestamp option is not available for user to query from Falcon metadata CLI and it will just be used internally. I will try to use vertex id now as discussed.
>
> Venkat Ranganathan wrote:
> I prefer the use of id to sort instead of changing the semantics of what the timestamp value is
Used vertex id instead of timestamp and FALCON-1643 is unblocked from this issue. I will fix the timestamp issue when vertex is getting added in graphdb.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111769
-----------------------------------------------------------
On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Venkat Ranganathan <n....@live.com>.
> On Dec. 23, 2015, 2:30 a.m., Ajay Yadava wrote:
> > I had an offline discussion with Peeyush Bishnoi over this. Here is the summary of the discussion.
> >
> > 1. We can use vertex id as the unique parameter
> > 2. Although there is no direct API leveraging timestamp, there is a REXSTER api exposed using which anyone can query any property, so all properties are in a way public contract.
> > 3. Using same property for nominal time can lead to issues if users don't migrate incorrect data. e.g. if users query over a time range which has both incorrect data and correct data, users will get several incorrect results. Using a second property will return no such wrong results.
> > 4. If we decide to use the same property then it's fine but it will be helpful to call out the change explicitly so that users are aware.
> >
> > Peeyush wants to try some more approaches, will get back on this after that.
>
> Peeyush Bishnoi wrote:
> Approach used in the attached patch to use nominal time for two purpose. First it provide unique timestamp for each entity instance so that sorting the vertices done easily (as it required for issue FALCON-1643). Second, instance vertices for an entity is getting created with similar actual time (despite some vertices get create later) so it looks a bug and also I have seen that nominal time is getting used other places instead of actual time.
>
> Peeyush Bishnoi wrote:
> Also I tried to use the timestamp in FALCON-1643, as timestamp option is not available for user to query from Falcon metadata CLI and it will just be used internally. I will try to use vertex id now as discussed.
I prefer the use of id to sort instead of changing the semantics of what the timestamp value is
- Venkat
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111769
-----------------------------------------------------------
On Dec. 17, 2015, 10:48 p.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 10:48 p.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Dec. 23, 2015, 10:30 a.m., Ajay Yadava wrote:
> > I had an offline discussion with Peeyush Bishnoi over this. Here is the summary of the discussion.
> >
> > 1. We can use vertex id as the unique parameter
> > 2. Although there is no direct API leveraging timestamp, there is a REXSTER api exposed using which anyone can query any property, so all properties are in a way public contract.
> > 3. Using same property for nominal time can lead to issues if users don't migrate incorrect data. e.g. if users query over a time range which has both incorrect data and correct data, users will get several incorrect results. Using a second property will return no such wrong results.
> > 4. If we decide to use the same property then it's fine but it will be helpful to call out the change explicitly so that users are aware.
> >
> > Peeyush wants to try some more approaches, will get back on this after that.
>
> Peeyush Bishnoi wrote:
> Approach used in the attached patch to use nominal time for two purpose. First it provide unique timestamp for each entity instance so that sorting the vertices done easily (as it required for issue FALCON-1643). Second, instance vertices for an entity is getting created with similar actual time (despite some vertices get create later) so it looks a bug and also I have seen that nominal time is getting used other places instead of actual time.
Also I tried to use the timestamp in FALCON-1643, as timestamp option is not available for user to query from Falcon metadata CLI and it will just be used internally. I will try to use vertex id now as discussed.
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111769
-----------------------------------------------------------
On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Ajay Yadava <aj...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111769
-----------------------------------------------------------
I had an offline discussion with Peeyush Bishnoi over this. Here is the summary of the discussion.
1. We can use vertex id as the unique parameter
2. Although there is no direct API leveraging timestamp, there is a REXSTER api exposed using which anyone can query any property, so all properties are in a way public contract.
3. Using same property for nominal time can lead to issues if users don't migrate incorrect data. e.g. if users query over a time range which has both incorrect data and correct data, users will get several incorrect results. Using a second property will return no such wrong results.
4. If we decide to use the same property then it's fine but it will be helpful to call out the change explicitly so that users are aware.
Peeyush wants to try some more approaches, will get back on this after that.
- Ajay Yadava
On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111134
-----------------------------------------------------------
Ship it!
Ship It!
- Balu Vellanki
On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by sandeep samudrala <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review111448
-----------------------------------------------------------
Ship it!
Ship It!
- sandeep samudrala
On Dec. 18, 2015, 6:48 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 18, 2015, 6:48 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/
-----------------------------------------------------------
(Updated Dec. 18, 2015, 6:48 a.m.)
Review request for Falcon.
Bugs: FALCON-1661
https://issues.apache.org/jira/browse/FALCON-1661
Repository: falcon-git
Description
-------
Similar timestamp is getting added for Falcon instance vertex in GraphDB
Diffs (updated)
-----
common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
Diff: https://reviews.apache.org/r/41505/diff/
Testing
-------
yes
Thanks,
Peeyush Bishnoi
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Peeyush Bishnoi <bp...@yahoo.co.in>.
> On Dec. 17, 2015, 5:16 p.m., Balu Vellanki wrote:
> > common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java, line 193
> > <https://reviews.apache.org/r/41505/diff/1/?file=1168538#file1168538line193>
> >
> > getTimeStampAsLong() and getNominalTimeStampAsLong() can be made into a single method to avoid code repetition.
Fixed
- Peeyush
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review110968
-----------------------------------------------------------
On Dec. 17, 2015, 11:20 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 11:20 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>
Re: Review Request 41505: FALCON-1661 : Similar timestamp is getting
added for Falcon instance vertex in GraphDB
Posted by Balu Vellanki <bv...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/41505/#review110968
-----------------------------------------------------------
common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java (line 193)
<https://reviews.apache.org/r/41505/#comment170987>
getTimeStampAsLong() and getNominalTimeStampAsLong() can be made into a single method to avoid code repetition.
- Balu Vellanki
On Dec. 17, 2015, 11:20 a.m., Peeyush Bishnoi wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/41505/
> -----------------------------------------------------------
>
> (Updated Dec. 17, 2015, 11:20 a.m.)
>
>
> Review request for Falcon.
>
>
> Bugs: FALCON-1661
> https://issues.apache.org/jira/browse/FALCON-1661
>
>
> Repository: falcon-git
>
>
> Description
> -------
>
> Similar timestamp is getting added for Falcon instance vertex in GraphDB
>
>
> Diffs
> -----
>
> common/src/main/java/org/apache/falcon/metadata/InstanceRelationshipGraphBuilder.java b709857
> common/src/main/java/org/apache/falcon/workflow/WorkflowExecutionContext.java f206ff1
> common/src/test/java/org/apache/falcon/metadata/MetadataMappingServiceTest.java 29f933d
>
> Diff: https://reviews.apache.org/r/41505/diff/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Peeyush Bishnoi
>
>