You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Vihang Karajgaonkar (Code Review)" <ge...@cloudera.org> on 2021/07/19 18:52:54 UTC

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum) 

Vihang Karajgaonkar has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17698


Change subject: IMPALA-10502: Fetch events in batches (Addendum)
......................................................................

IMPALA-10502: Fetch events in batches (Addendum)

The earlier change for IMPALA-10502 passes in a batch size
of -1 to fetch all the events from a given event id during a
DDL execution. While this works when HMS backing database is
postgres, it doesn't work well when the HMS backend
is a MySQL database due to HIVE-20226. This change works around the hive
bug to fetch the events in batches of 1000 instead of fetching all the events
in one RPC during the DDL execution.

Testing:
1. Added a unit test for the new changes introduced.
2. Ran the previously failing tests on MySQL HMS backend.

Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M fe/src/test/java/org/apache/impala/catalog/events/SynchronousHMSEventProcessorForTests.java
4 files changed, 53 insertions(+), 31 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/98/17698/1
-- 
To view, visit http://gerrit.cloudera.org:8080/17698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17698 )

Change subject: IMPALA-10502: Fetch events in batches (Addendum)
......................................................................


Patch Set 2:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7320/ DRY_RUN=false


-- 
To view, visit http://gerrit.cloudera.org:8080/17698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 02:35:48 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17698 )

Change subject: IMPALA-10502: Fetch events in batches (Addendum)
......................................................................


Patch Set 1: Verified+1


-- 
To view, visit http://gerrit.cloudera.org:8080/17698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 03:30:38 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17698 )

Change subject: IMPALA-10502: Fetch events in batches (Addendum)
......................................................................


Patch Set 2: Verified-1

Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/7320/


-- 
To view, visit http://gerrit.cloudera.org:8080/17698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 08:54:59 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17698 )

Change subject: IMPALA-10502: Fetch events in batches (Addendum)
......................................................................


Patch Set 1:

Build Successful 

https://jenkins.impala.io/job/gerrit-code-review-checks/9119/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.


-- 
To view, visit http://gerrit.cloudera.org:8080/17698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 19:22:11 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has posted comments on this change. ( http://gerrit.cloudera.org:8080/17698 )

Change subject: IMPALA-10502: Fetch events in batches (Addendum)
......................................................................


Patch Set 2: Verified+1 Code-Review+2

LGTM!

Also Verify +1 because build #7320 failed with a known issue (IMPALA-10754). And there was already a good GVO, #7316.


-- 
To view, visit http://gerrit.cloudera.org:8080/17698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 13:33:58 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17698 )

Change subject: IMPALA-10502: Fetch events in batches (Addendum)
......................................................................


Patch Set 2: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/17698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 02:35:47 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17698 )

Change subject: IMPALA-10502: Fetch events in batches (Addendum)
......................................................................

IMPALA-10502: Fetch events in batches (Addendum)

The earlier change for IMPALA-10502 passes in a batch size
of -1 to fetch all the events from a given event id during a
DDL execution. While this works when HMS backing database is
postgres, it doesn't work well when the HMS backend
is a MySQL database due to HIVE-20226. This change works around the hive
bug to fetch the events in batches of 1000 instead of fetching all the events
in one RPC during the DDL execution.

Testing:
1. Added a unit test for the new changes introduced.
2. Ran the previously failing tests on MySQL HMS backend.

Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Reviewed-on: http://gerrit.cloudera.org:8080/17698
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Reviewed-by: Zoltan Borok-Nagy <bo...@cloudera.com>
Tested-by: Zoltan Borok-Nagy <bo...@cloudera.com>
---
M fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
M fe/src/main/java/org/apache/impala/service/CatalogOpExecutor.java
M fe/src/test/java/org/apache/impala/catalog/events/MetastoreEventsProcessorTest.java
M fe/src/test/java/org/apache/impala/catalog/events/SynchronousHMSEventProcessorForTests.java
4 files changed, 53 insertions(+), 31 deletions(-)

Approvals:
  Impala Public Jenkins: Looks good to me, approved
  Zoltan Borok-Nagy: Looks good to me, approved; Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/17698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 3
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17698 )

Change subject: IMPALA-10502: Fetch events in batches (Addendum)
......................................................................


Patch Set 1:

Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7316/ DRY_RUN=true


-- 
To view, visit http://gerrit.cloudera.org:8080/17698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Mon, 19 Jul 2021 21:15:35 +0000
Gerrit-HasComments: No

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

Posted by "Zoltan Borok-Nagy (Code Review)" <ge...@cloudera.org>.
Zoltan Borok-Nagy has removed a vote on this change.

Change subject: IMPALA-10502: Fetch events in batches (Addendum)
......................................................................


Removed Verified-1 by Impala Public Jenkins <im...@cloudera.com>
-- 
To view, visit http://gerrit.cloudera.org:8080/17698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 2
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17698 )

Change subject: IMPALA-10502: Fetch events in batches (Addendum)
......................................................................


Patch Set 1: Code-Review+2

(1 comment)

LGTM

http://gerrit.cloudera.org:8080/#/c/17698/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:

http://gerrit.cloudera.org:8080/#/c/17698/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@291
PS1, Line 291: currentEventId = event.getEventId();
> This assumes that events are returned in the order with increasing event id
As discussed offline, we already depend on this in these places:
https://github.com/apache/impala/blob/62028d00e657c65cd23e16794dff18149f1dbe0e/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java#L709
https://github.com/apache/impala/blob/62028d00e657c65cd23e16794dff18149f1dbe0e/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java#L723

So it's ok for now.



-- 
To view, visit http://gerrit.cloudera.org:8080/17698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 02:35:14 +0000
Gerrit-HasComments: Yes

[Impala-ASF-CR] IMPALA-10502: Fetch events in batches (Addendum)

Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/17698 )

Change subject: IMPALA-10502: Fetch events in batches (Addendum)
......................................................................


Patch Set 1:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/17698/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java
File fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java:

http://gerrit.cloudera.org:8080/#/c/17698/1/fe/src/main/java/org/apache/impala/catalog/events/MetastoreEventsProcessor.java@291
PS1, Line 291: currentEventId = event.getEventId();
This assumes that events are returned in the order with increasing event id. Is it always true?



-- 
To view, visit http://gerrit.cloudera.org:8080/17698
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I34bb8984aeb91b37439f77722746f638d8774478
Gerrit-Change-Number: 17698
Gerrit-PatchSet: 1
Gerrit-Owner: Vihang Karajgaonkar <vi...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Zoltan Borok-Nagy <bo...@cloudera.com>
Gerrit-Comment-Date: Tue, 20 Jul 2021 01:29:11 +0000
Gerrit-HasComments: Yes