You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "stevomitric (via GitHub)" <gi...@apache.org> on 2026/07/07 15:22:14 UTC

[PR] [WIP][SPARK-57813][SQL] Support nanosecond-precision timestamp types as file-source partition columns [spark]

stevomitric opened a new pull request, #57082:
URL: https://github.com/apache/spark/pull/57082

   ### What changes were proposed in this pull request?
   
   Widen the timestamp guard in `PartitioningUtils.castPartValueToDesiredType` so that partition values are cast when the desired partition-column type is an `AnyTimestampNanoType` (`TimestampNTZNanosType`/`TimestampLTZNanosType` at precision 7-9)
   
   ### Why are the changes needed?
   
   Without this, dynamically writing then reading back a table partitioned on a nanosecond-precision timestamp column failed to reconstruct the partition value and raised `INVALID_PARTITION_VALUE` when casting the escaped directory name to the declared nanos type.
   
   ### Does this PR introduce _any_ user-facing change?
   
   Yes. Nanosecond-precision timestamp columns (`TIMESTAMP_NTZ(p)`/`TIMESTAMP_LTZ(p)`, p in [7, 9]) can now be used as file-source partition columns.
   
   ### How was this patch tested?
   
   Added `PartitionedWriteSuite` coverage: write-then-read round-trip for both NTZ and LTZ nanos partition columns.
   
   ### Was this patch authored or co-authored using generative AI tooling?
   Generated-by: Claude Opus 4.8


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57813][SQL] Support nanosecond-precision timestamp types as file-source partition columns [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan commented on PR #57082:
URL: https://github.com/apache/spark/pull/57082#issuecomment-4925113078

   **Merge Summary:**
   - merged into master https://github.com/apache/spark/commit/18df87b9f5b56dafc69394e3673cf37071954333
   - merged into branch-4.x https://github.com/apache/spark/commit/adad41358ec1170f5218bf35c4b5076550c52591
   
   *Posted by `merge_spark_pr.py`*


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57813][SQL] Support nanosecond-precision timestamp types as file-source partition columns [spark]

Posted by "cloud-fan (via GitHub)" <gi...@apache.org>.
cloud-fan closed pull request #57082: [SPARK-57813][SQL] Support nanosecond-precision timestamp types as file-source partition columns
URL: https://github.com/apache/spark/pull/57082


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


Re: [PR] [SPARK-57813][SQL] Support nanosecond-precision timestamp types as file-source partition columns [spark]

Posted by "stevomitric (via GitHub)" <gi...@apache.org>.
stevomitric commented on PR #57082:
URL: https://github.com/apache/spark/pull/57082#issuecomment-4913959844

   cc @uros-b, @cloud-fan PTAL at this PR.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org