You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@beam.apache.org by "ASF GitHub Bot (Jira)" <ji...@apache.org> on 2020/08/18 23:59:00 UTC
[jira] [Work logged] (BEAM-10757) Python license check precommit
broken for enum34
[ https://issues.apache.org/jira/browse/BEAM-10757?focusedWorklogId=472199&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-472199 ]
ASF GitHub Bot logged work on BEAM-10757:
-----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Aug/20 23:58
Start Date: 18/Aug/20 23:58
Worklog Time Spent: 10m
Work Description: jkff opened a new pull request #12624:
URL: https://github.com/apache/beam/pull/12624
The original repo https://bitbucket.org/stoneleaf/enum34 is down now.
I took the license from somebody's clone on github https://github.com/jamespharaoh/python-enum34
------------------------
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Dataflow | Flink | Samza | Spark | Twister2
--- | --- | --- | --- | --- | --- | ---
Go | [](https://ci-beam.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/) | ---
Java | [](https://ci-beam.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink_Java11/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/) | [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Twister2/lastCompletedBuild/)
Python | [](https://ci-beam.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python38/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/) | ---
XLang | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Direct/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/) | --- | [](https://ci-beam.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/) | ---
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://ci-beam.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)<br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocker_Cron/lastCompletedBuild/) <br>[](https://ci-beam.apache.org/job/beam_PreCommit_PythonDocs_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/) | [](https://ci-beam.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://ci-beam.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/) | --- | ---
See [.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md) for trigger phrase, status and link of all Jenkins jobs.
GitHub Actions Tests Status (on master branch)
------------------------------------------------------------------------------------------------
See [CI.md](https://github.com/apache/beam/blob/master/CI.md) for more information about GitHub Actions CI.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 472199)
Remaining Estimate: 0h
Time Spent: 10m
> Python license check precommit broken for enum34
> ------------------------------------------------
>
> Key: BEAM-10757
> URL: https://issues.apache.org/jira/browse/BEAM-10757
> Project: Beam
> Issue Type: Bug
> Components: test-failures
> Reporter: Valentyn Tymofieiev
> Assignee: Eugene Kirpichov
> Priority: P0
> Time Spent: 10m
> Remaining Estimate: 0h
>
> ```
> ERROR:root:Error occurred when pull license for enum34 from {'license': 'https://bitbucket.org/stoneleaf/enum34/raw/c208549a93b71b948ff7bbdfd29dce8f85527916/enum/LICENSE'}.
> 16:06:02 Traceback (most recent call last):
> 16:06:02 File "/tmp/license_scripts/pull_licenses_py.py", line 94, in pull_from_url
> 16:06:02 url_read = urlopen(config['license'])
> 16:06:02 File "/usr/local/lib/python2.7/urllib2.py", line 154, in urlopen
> 16:06:02 �[0m�[91m return opener.open(url, data, timeout)
> 16:06:02 File "/usr/local/lib/python2.7/urllib2.py", line 435, in open
> 16:06:02 response = meth(req, response)
> 16:06:02 File "/usr/local/lib/python2.7/urllib2.py", line 548, in http_response
> 16:06:02 'http', request, response, code, msg, hdrs)
> 16:06:02 File "/usr/local/lib/python2.7/urllib2.py", line 473, in error
> 16:06:02 return self._call_chain(*args)
> 16:06:02 �[0m�[91m File "/usr/local/lib/python2.7/urllib2.py", line 407, in _call_chain
> 16:06:02 result = func(*args)
> 16:06:02 File "/usr/local/lib/python2.7/urllib2.py", line 556, in http_error_default
> ```
> I am not sure where is the source of truth for the license now. We can retrieve the license from a released container, check it in Beam repo and reference it as a manual license, see, for example: https://github.com/apache/beam/blob/0d362dd4d2d660b4cdf40f6b87b3fa10965098e1/sdks/python/container/license_scripts/dep_urls_py.yaml#L108.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)