[jira] [Commented] (YARN-1690) Sending timeline entities+events from Distributed shell

["Mayank Bansal (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-1690?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13939598#comment-13939598 ] 

Mayank Bansal commented on YARN-1690:
-------------------------------------

Thanks [~zjshen] for the review

bq . 1. Call it DSEvent?
Done
bq. 2. Chang it to Timeline Client?
Done
bq.3. Typo on "CLient"
Done
bq. config is the member field of ApplicationMaster
Done
bq. 5. Please merge the following duplicate exception handling as well
Done
bq. 6. Again, please do not mention "AHS" here
Done
bq.7. Please change publishContainerStartEvent, publishContainerEndEvent, publishApplicationAttemptEvent to static, which don't need to be per instance.
Done
bq.8. Please apply for the following to all the added error logs.
Done
bq.9. Please don't limit the output to 1. According to the args for this DS job, it should be 1 DS_APP_ATTEMPT entities and 2 DS_CONTAINER entities, which has 2 events each? And assert the number of returned entities/events?
Done

> Sending timeline entities+events from Distributed shell 
> --------------------------------------------------------
>
>                 Key: YARN-1690
>                 URL: https://issues.apache.org/jira/browse/YARN-1690
>             Project: Hadoop YARN
>          Issue Type: Sub-task
>            Reporter: Mayank Bansal
>            Assignee: Mayank Bansal
>         Attachments: YARN-1690-1.patch, YARN-1690-2.patch, YARN-1690-3.patch, YARN-1690-4.patch, YARN-1690-5.patch
>
>




--
This message was sent by Atlassian JIRA
(v6.2#6252)