You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@beam.apache.org by GitBox <gi...@apache.org> on 2021/06/04 22:06:01 UTC

[GitHub] [beam] ibzib commented on pull request #14938: [BEAM-11811] Disallow num_workers > max_num_workers for Python DataflowRunner

ibzib commented on pull request #14938:
URL: https://github.com/apache/beam/pull/14938#issuecomment-855030476


   > Ok, didn't see that.
   > 
   > Would it perhaps be better to make it part of WorkerOptions.validate rather than add it directly to PipelineOptionsValidator?
   
   WorkerOptions.validate calls methods in PipelineOptionsValidator, so I'm not sure what you mean. https://github.com/apache/beam/blob/92386d781b5d502c4ea47a0894b72ca57854553d/sdks/python/apache_beam/options/pipeline_options.py#L934
   
   Putting most of the actual logic into PipelineOptionsValidator is preferable though (similar to existing code).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org