[GitHub] [trafficcontrol] rob05c opened a new pull request #3944: Fix TO missing returns after HandleErr

[GitBox <gi...@apache.org>]

rob05c opened a new pull request #3944: Fix TO missing returns after HandleErr
URL: https://github.com/apache/trafficcontrol/pull/3944
 
 
   This isn't technically a bug, because I added a saftey some time ago
   which detects the double-response, logs it, and doesn't respond with
   the second one.
   
   But, it's still an error. TO shouldn't keep processing and doing
   pointless things after an error.
   
   - [x] This PR is not related to any other Issue
   
   Tests already exist for these endpoints. This doesn't actually change behavior, because there's a safety check to not double-return to the user, so it's not possible to test.
   
   No documentation, no interface change.
   
   No changelog, no visible behavior change.
   
   ## Which Traffic Control components are affected by this PR?
   - Traffic Ops
   
   ## What is the best way to verify this PR?
   
   Verify API Tests pass.
   
   ## If this is a bug fix, what versions of Traffic Control are affected?
   
   Not a bug fix.
   
   
   ## The following criteria are ALL met by this PR
   
   - [x] This PR includes tests OR I have explained why tests are unnecessary
   - [x] This PR includes documentation OR I have explained why documentation is unnecessary
   - [x] This PR includes an update to CHANGELOG.md OR such an update is not necessary
   - [x] This PR includes any and all required license headers
   - [x] This PR ensures that database migration sequence is correct OR this PR does not include a database migration
   - [x] This PR **DOES NOT FIX A SERIOUS SECURITY VULNERABILITY** (see [the Apache Software Foundation's security guidelines](https://www.apache.org/security/) for details)
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services