Re: [PR] [Improvement] Audit log Improvement [dolphinscheduler]

["SbloodyS (via GitHub)" <gi...@apache.org>]

SbloodyS commented on code in PR #15554:
URL: https://github.com/apache/dolphinscheduler/pull/15554#discussion_r1508703003


##########
dolphinscheduler-dao/src/main/resources/sql/upgrade/3.3.0_schema/postgresql/dolphinscheduler_ddl.sql:
##########
@@ -0,0 +1,41 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements.  See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License.  You may obtain a copy of the License at
+ *
+ *    http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+*/
+-- modify_data_t_ds_audit_log_input_entry
+delimiter d//
+CREATE OR REPLACE FUNCTION modify_data_t_ds_audit_log_input_entry() RETURNS void AS $$
+BEGIN
+      IF EXISTS (SELECT 1
+                  FROM information_schema.columns
+                  WHERE table_name = 't_ds_audit_log'
+                  AND column_name = 'resource_type')
+      THEN
+ALTER TABLE t_ds_audit_log
+    drop resource_type, drop operation, drop resource_id,
+    add object_id       bigint NOT NULL,
+    add object_name     VARCHAR(255) NOT NULL,
+    add object_type     int NOT NULL,
+    add operation_type  int NOT NULL,
+    add description     VARCHAR(255) NOT NULL,
+    add latency         int NOT NULL,
+    add detail          VARCHAR(255) DEFAULT NULL;
+END IF;
+END;
+$$ LANGUAGE plpgsql;
+d//
+
+select modify_data_t_ds_audit_log_input_entry();
+DROP FUNCTION IF EXISTS modify_data_t_ds_audit_log_input_entry();

Review Comment:
   We should leave a blank line in the bottom of every file.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org