[jira] [Commented] (AMQ-5990) PooledConnectionFactory does not allow disabling JMX on GenericKeyObjectPool

["Timothy Bish (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/AMQ-5990?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14940076#comment-14940076 ] 

Timothy Bish commented on AMQ-5990:
-----------------------------------

Allowing access to the configuration of the underlying pool could result in a broker Connection pool given how the PooledConnection bits work, I'd recommend just turning off the JMX bits by default in the pool. 

> PooledConnectionFactory does not allow disabling JMX on GenericKeyObjectPool
> ----------------------------------------------------------------------------
>
>                 Key: AMQ-5990
>                 URL: https://issues.apache.org/jira/browse/AMQ-5990
>             Project: ActiveMQ
>          Issue Type: Bug
>            Reporter: Aravind Chennuru
>            Assignee: Christopher L. Shannon
>             Fix For: 5.12.1
>
>         Attachments: patchfile.txt
>
>
> initConnectionPool does not allow us to configure the GenericKeyObjectPool.
> Suggestion:
> PooledConnectionFactory
> {code}
> private GenericKeyedObjectPoolConfig config;
> public void setBasePoolConfig(final GenericKeyedObjectPoolConfig config) {
>         this.config = config;
> }
> public void initConnectionsPool() {
>      if (this.connectionsPool == null) {
>             this.connectionsPool = new GenericKeyedObjectPool<ConnectionKey, ConnectionPool>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
>      }
> }
> protected ConnectionPool createConnectionPool(Connection connection) {
>         return new ConnectionPool(connection, config);
>     }
> {code}
> ConnectionPool
> {code}
> public ConnectionPool(Connection connection) {
>       this(connection, new GenericKeyedObjectPoolConfig());
> }
> public ConnectionPool(Connection connection, GenericKeyedObjectPoolConfig config) {
>       this.connection = wrap(connection);
>       this.sessionPool = new GenericKeyedObjectPool<SessionKey, SessionHolder>(blah, config==null?new GenericKeyedObjectPoolConfig():config);
> }
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)