You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@servicemix.apache.org by "Guillaume Nodet (JIRA)" <ji...@apache.org> on 2006/03/31 09:47:13 UTC
[jira] Reopened: (SM-372) HTTPS support for the servicemix-http
component
[ https://issues.apache.org/activemq/browse/SM-372?page=all ]
Guillaume Nodet reopened SM-372:
--------------------------------
We usually put the issue to resolved when the fix / feature has been checked in svn ;)
Thanks for this patch anyway.
I have however a few comments / modifications:
1) the ServerManager is a singleton (own by the component) but there is one ConsumerProcessor per endpoint, so we need to give the parameters to the ServerManager in another way.
2) I'm not sure of the need to specify these parameters on a per endpoint basis. At least, they should be available on the global configuration for the component (org.apache.servicemix.http.HttpConfiguration / HttpConfigurationMBean) so that default values can be retrieved there. Be aware that the configuration is self-persistent... Another point is that there is only one SslSocketConnector for a given port, so you can not configure several endpoints on the same port with different parameters.
3) minor ;) when the ConsumerConnector is created, it already reads some informations from the endpoint. I guess it would be more consistent if he reads ssl configuration from the endpoint in the constructor instead of the endpoint setting them
I can do that if you prefer, but feel free to go if you wish !
> HTTPS support for the servicemix-http component
> -----------------------------------------------
>
> Key: SM-372
> URL: https://issues.apache.org/activemq/browse/SM-372
> Project: ServiceMix
> Type: New Feature
> Reporter: Mike Gerdes
> Fix For: incubation
> Attachments: ConsumerProcessor.java, HttpEndpoint.java, ServerManager.java
>
>
> Added support for the servicemix-http component.
--
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators:
https://issues.apache.org/activemq/secure/Administrators.jspa
-
For more information on JIRA, see:
http://www.atlassian.com/software/jira