You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@qpid.apache.org by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org> on 2010/06/10 16:43:12 UTC
[jira] Created: (QPID-2657) Verify/correct error handling on client
0-10 codepath
Verify/correct error handling on client 0-10 codepath
-----------------------------------------------------
Key: QPID-2657
URL: https://issues.apache.org/jira/browse/QPID-2657
Project: Qpid
Issue Type: Bug
Affects Versions: 0.7
Reporter: Andrew Kennedy
Fix For: 0.7
Verify and correct existing error handling on 0-10 CLIENT codepath:
- whats the structure and how does it compare with whats there on the 0-9 codepath ?
- do errors thrown to the client from the broker have the correct result on an open connection/session/producer/consumer ?
- is logging correctly implemented ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [jira] Commented: (QPID-2657) Verify/correct error handling on
client 0-10 codepath
Posted by Rajith Attapattu <ra...@gmail.com>.
On Thu, Jun 17, 2010 at 10:47 AM, Andrew Kennedy
<an...@gmail.com> wrote:
> On 17 June 2010 15:00, Rajith Attapattu (JIRA)
> <qp...@incubator.apache.org> wrote:
>>
>> [ https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879784#action_12879784 ]
>>
>> Rajith Attapattu commented on QPID-2657:
>> ----------------------------------------
>>
>> Ah my bad, there was a local modification in my code when the patch was applied, and due to that I misunderstood that particular code segment.
>> I failed to realize that you had merely rearranged the code there.
>>
>> Btw question (3) still stands :)
>
>>> 3. Have you run the tests against the 0-10 cpp broker profiles?
>
> Rajith,
>
> I haven't done that *yet*, as this is still a work in progress - there
> are a few issues I still have to straighten out before this JIRA is
> resolved. I will make sure I test against the C++ broker as well for
> all the 0-10 work I'm doing, as a matter of course, so that I catch
> any issues quickly.
>
> Andrew.
Andrew thx a lot !
> --
> -- andrew d kennedy ? edinburgh : +44 7941 197 134
>
> ---------------------------------------------------------------------
> Apache Qpid - AMQP Messaging Implementation
> Project: http://qpid.apache.org
> Use/Interact: mailto:dev-subscribe@qpid.apache.org
>
>
--
Regards,
Rajith Attapattu
Red Hat
http://rajith.2rlabs.com/
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
Re: [jira] Commented: (QPID-2657) Verify/correct error handling on
client 0-10 codepath
Posted by Andrew Kennedy <an...@gmail.com>.
On 17 June 2010 15:00, Rajith Attapattu (JIRA)
<qp...@incubator.apache.org> wrote:
>
> [ https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879784#action_12879784 ]
>
> Rajith Attapattu commented on QPID-2657:
> ----------------------------------------
>
> Ah my bad, there was a local modification in my code when the patch was applied, and due to that I misunderstood that particular code segment.
> I failed to realize that you had merely rearranged the code there.
>
> Btw question (3) still stands :)
>> 3. Have you run the tests against the 0-10 cpp broker profiles?
Rajith,
I haven't done that *yet*, as this is still a work in progress - there
are a few issues I still have to straighten out before this JIRA is
resolved. I will make sure I test against the C++ broker as well for
all the 0-10 work I'm doing, as a matter of course, so that I catch
any issues quickly.
Andrew.
--
-- andrew d kennedy ? edinburgh : +44 7941 197 134
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2657) Verify/correct error handling on
client 0-10 codepath
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879784#action_12879784 ]
Rajith Attapattu commented on QPID-2657:
----------------------------------------
Ah my bad, there was a local modification in my code when the patch was applied, and due to that I misunderstood that particular code segment.
I failed to realize that you had merely rearranged the code there.
Btw question (3) still stands :)
> Verify/correct error handling on client 0-10 codepath
> -----------------------------------------------------
>
> Key: QPID-2657
> URL: https://issues.apache.org/jira/browse/QPID-2657
> Project: Qpid
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
> Attachments: 0003-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch
>
>
> Verify and correct existing error handling on 0-10 CLIENT codepath:
> - whats the structure and how does it compare with whats there on the 0-9 codepath ?
> - do errors thrown to the client from the broker have the correct result on an open connection/session/producer/consumer ?
> - is logging correctly implemented ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2657) Verify/correct error handling on client
0-10 codepath
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2657:
---------------------------------
Attachment: (was: 0005-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch)
> Verify/correct error handling on client 0-10 codepath
> -----------------------------------------------------
>
> Key: QPID-2657
> URL: https://issues.apache.org/jira/browse/QPID-2657
> Project: Qpid
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
> Attachments: 0003-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch
>
>
> Verify and correct existing error handling on 0-10 CLIENT codepath:
> - whats the structure and how does it compare with whats there on the 0-9 codepath ?
> - do errors thrown to the client from the broker have the correct result on an open connection/session/producer/consumer ?
> - is logging correctly implemented ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2657) Verify/correct error handling on client
0-10 codepath
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2657:
---------------------------------
Attachment: (was: 0003-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch)
> Verify/correct error handling on client 0-10 codepath
> -----------------------------------------------------
>
> Key: QPID-2657
> URL: https://issues.apache.org/jira/browse/QPID-2657
> Project: Qpid
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
>
> Verify and correct existing error handling on 0-10 CLIENT codepath:
> - whats the structure and how does it compare with whats there on the 0-9 codepath ?
> - do errors thrown to the client from the broker have the correct result on an open connection/session/producer/consumer ?
> - is logging correctly implemented ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Resolved: (QPID-2657) Verify/correct error handling on
client 0-10 codepath
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell resolved QPID-2657.
----------------------------------
Resolution: Fixed
> Verify/correct error handling on client 0-10 codepath
> -----------------------------------------------------
>
> Key: QPID-2657
> URL: https://issues.apache.org/jira/browse/QPID-2657
> Project: Qpid
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> Verify and correct existing error handling on 0-10 CLIENT codepath:
> - whats the structure and how does it compare with whats there on the 0-9 codepath ?
> - do errors thrown to the client from the broker have the correct result on an open connection/session/producer/consumer ?
> - is logging correctly implemented ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2657) Verify/correct error handling on client
0-10 codepath
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2657:
---------------------------------
Attachment: (was: 0001-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch)
> Verify/correct error handling on client 0-10 codepath
> -----------------------------------------------------
>
> Key: QPID-2657
> URL: https://issues.apache.org/jira/browse/QPID-2657
> Project: Qpid
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
>
> Verify and correct existing error handling on 0-10 CLIENT codepath:
> - whats the structure and how does it compare with whats there on the 0-9 codepath ?
> - do errors thrown to the client from the broker have the correct result on an open connection/session/producer/consumer ?
> - is logging correctly implemented ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2657) Verify/correct error handling on client
0-10 codepath
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2657:
---------------------------------
Attachment: 0003-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch
Updated with fixes for close race condition.
> Verify/correct error handling on client 0-10 codepath
> -----------------------------------------------------
>
> Key: QPID-2657
> URL: https://issues.apache.org/jira/browse/QPID-2657
> Project: Qpid
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
> Attachments: 0003-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch
>
>
> Verify and correct existing error handling on 0-10 CLIENT codepath:
> - whats the structure and how does it compare with whats there on the 0-9 codepath ?
> - do errors thrown to the client from the broker have the correct result on an open connection/session/producer/consumer ?
> - is logging correctly implemented ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2657) Verify/correct error handling on client
0-10 codepath
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2657:
---------------------------------
Attachment: 0005-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch
> Verify/correct error handling on client 0-10 codepath
> -----------------------------------------------------
>
> Key: QPID-2657
> URL: https://issues.apache.org/jira/browse/QPID-2657
> Project: Qpid
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
> Attachments: 0005-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch
>
>
> Verify and correct existing error handling on 0-10 CLIENT codepath:
> - whats the structure and how does it compare with whats there on the 0-9 codepath ?
> - do errors thrown to the client from the broker have the correct result on an open connection/session/producer/consumer ?
> - is logging correctly implemented ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Assigned: (QPID-2657) Verify/correct error handling on
client 0-10 codepath
Posted by "Robbie Gemmell (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Robbie Gemmell reassigned QPID-2657:
------------------------------------
Assignee: Robbie Gemmell
> Verify/correct error handling on client 0-10 codepath
> -----------------------------------------------------
>
> Key: QPID-2657
> URL: https://issues.apache.org/jira/browse/QPID-2657
> Project: Qpid
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Assignee: Robbie Gemmell
> Fix For: 0.7
>
>
> Verify and correct existing error handling on 0-10 CLIENT codepath:
> - whats the structure and how does it compare with whats there on the 0-9 codepath ?
> - do errors thrown to the client from the broker have the correct result on an open connection/session/producer/consumer ?
> - is logging correctly implemented ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Commented: (QPID-2657) Verify/correct error handling on
client 0-10 codepath
Posted by "Rajith Attapattu (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12879773#action_12879773 ]
Rajith Attapattu commented on QPID-2657:
----------------------------------------
First of all, thanks for doing this.
I have been meaning to do this for a while now.
I have the following questions about the patch.
In @@ -139,36 +139,24 @@ public class BasicMessageConsumer_0_10 ... you have added the following code.
+ if (isMessageListenerSet() && capacity == 0)
+ {
+ _0_10session.getQpidSession().messageFlow(getConsumerTagString(),
+ MessageCreditUnit.MESSAGE, 1,
+ Option.UNRELIABLE);
+ }
+ _logger.debug("messageOk, trying to notify");
+ super.notifyMessage(jmsMessage);
1. What is the reason for adding this?
2. How is this related to exception handling? (or is this part of some other JIRA that got accidentally added to this patch ?)
3. Have you run the tests against the 0-10 cpp broker profiles?
In general If any code is modified in the 0-10 client side, I'd like to kindly request that the 0-10 cpp broker test profiles are run before the patch is committed.
> Verify/correct error handling on client 0-10 codepath
> -----------------------------------------------------
>
> Key: QPID-2657
> URL: https://issues.apache.org/jira/browse/QPID-2657
> Project: Qpid
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
> Attachments: 0003-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch
>
>
> Verify and correct existing error handling on 0-10 CLIENT codepath:
> - whats the structure and how does it compare with whats there on the 0-9 codepath ?
> - do errors thrown to the client from the broker have the correct result on an open connection/session/producer/consumer ?
> - is logging correctly implemented ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org
[jira] Updated: (QPID-2657) Verify/correct error handling on client
0-10 codepath
Posted by "Andrew Kennedy (JIRA)" <qp...@incubator.apache.org>.
[ https://issues.apache.org/jira/browse/QPID-2657?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Andrew Kennedy updated QPID-2657:
---------------------------------
Attachment: 0001-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch
> Verify/correct error handling on client 0-10 codepath
> -----------------------------------------------------
>
> Key: QPID-2657
> URL: https://issues.apache.org/jira/browse/QPID-2657
> Project: Qpid
> Issue Type: Bug
> Affects Versions: 0.7
> Reporter: Andrew Kennedy
> Fix For: 0.7
>
> Attachments: 0001-QPID-2657-Make-Exceptions-propagate-to-client-for-0.patch
>
>
> Verify and correct existing error handling on 0-10 CLIENT codepath:
> - whats the structure and how does it compare with whats there on the 0-9 codepath ?
> - do errors thrown to the client from the broker have the correct result on an open connection/session/producer/consumer ?
> - is logging correctly implemented ?
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:dev-subscribe@qpid.apache.org