You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2018/07/17 23:55:04 UTC

[GitHub] reddycharan opened a new pull request #1557: ISSUE #1541: Fix ReadOnlyBookie constructor

reddycharan opened a new pull request #1557: ISSUE #1541: Fix ReadOnlyBookie constructor
URL: https://github.com/apache/bookkeeper/pull/1557
 
 
   
   Descriptions of the changes in this PR:
   
   
   ### Motivation
   
   ReadOnlyBookie doesn't sets shutdownHandler to its statemanager.
   
   There are couple of issues with how 'stateManager' is handled in ReadOnlyBookie,
   
   - ReadOnlyBookie creates its own stateManager in its constructor but it does not sets shutdownHandler.
   - Also, it is not correct to create stateManager instance in Bookie constructor and then again in ReadOnlyBookie constructor and override the instance created in super constructor. 
   
   ### Changes
   
   - move initializeStateManager logic to a method and override it in ReadOnlyBookie.
   
   Master Issue: #1541 
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services