You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@poi.apache.org by David North <dt...@corefiling.co.uk> on 2015/10/07 11:54:48 UTC
Running tests before commit
Apologies for the forbidden APIs failures I introduced yesterday - I'd
forgotten it would now be necessary to run that check before commit.
Having been through the build file, it looks like the safe thing to do
is "ant jenkins" before each commit to match the CI system.
Thanks,
David
--
David North, Technical Lead, CoreFiling Limited
http://www.corefiling.com
Phone: +44-1865-203192
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: Running tests before commit
Posted by David North <dt...@corefiling.co.uk>.
That's now done. Thanks for the suggestion.
On 07/10/15 11:21, Javen O'Neal wrote:
> Perhaps it'd be worth adding this target to How To Build
> http://poi.apache.org/howtobuild.html#Building+Targets+with+Ant
> Javen O'Neal
>
>
> On Wed, Oct 7, 2015 at 2:54 AM, David North <dt...@corefiling.co.uk> wrote:
>> Apologies for the forbidden APIs failures I introduced yesterday - I'd
>> forgotten it would now be necessary to run that check before commit.
>>
>> Having been through the build file, it looks like the safe thing to do
>> is "ant jenkins" before each commit to match the CI system.
>>
>> Thanks,
>> David
>>
>> --
>> David North, Technical Lead, CoreFiling Limited
>> http://www.corefiling.com
>> Phone: +44-1865-203192
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
>> For additional commands, e-mail: dev-help@poi.apache.org
>>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
--
David North, Technical Lead, CoreFiling Limited
http://www.corefiling.com
Phone: +44-1865-203192
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: Running tests before commit
Posted by Dustin Spicuzza <du...@virtualroadside.com>.
Yes, I ran tests but didn't know there was a Jenkins target.
On Oct 7, 2015 6:21 AM, Javen O'Neal <ja...@gmail.com> wrote:
>
> Perhaps it'd be worth adding this target to How To Build
> http://poi.apache.org/howtobuild.html#Building+Targets+with+Ant
> Javen O'Neal
>
>
> On Wed, Oct 7, 2015 at 2:54 AM, David North <dt...@corefiling.co.uk> wrote:
> > Apologies for the forbidden APIs failures I introduced yesterday - I'd
> > forgotten it would now be necessary to run that check before commit.
> >
> > Having been through the build file, it looks like the safe thing to do
> > is "ant jenkins" before each commit to match the CI system.
> >
> > Thanks,
> > David
> >
> > --
> > David North, Technical Lead, CoreFiling Limited
> > http://www.corefiling.com
> > Phone: +44-1865-203192
> >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> > For additional commands, e-mail: dev-help@poi.apache.org
> >
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
Re: Running tests before commit
Posted by Javen O'Neal <ja...@gmail.com>.
Perhaps it'd be worth adding this target to How To Build
http://poi.apache.org/howtobuild.html#Building+Targets+with+Ant
Javen O'Neal
On Wed, Oct 7, 2015 at 2:54 AM, David North <dt...@corefiling.co.uk> wrote:
> Apologies for the forbidden APIs failures I introduced yesterday - I'd
> forgotten it would now be necessary to run that check before commit.
>
> Having been through the build file, it looks like the safe thing to do
> is "ant jenkins" before each commit to match the CI system.
>
> Thanks,
> David
>
> --
> David North, Technical Lead, CoreFiling Limited
> http://www.corefiling.com
> Phone: +44-1865-203192
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
> For additional commands, e-mail: dev-help@poi.apache.org
>
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org
Re: Running tests before commit
Posted by kiwiwings <ki...@apache.org>.
I usually just run "ant clean test" and sometimes "ant forbbiden-apis-check".
When I've added new files, I usually execute "ant rat".
Of course, I also blush when my changes lead to failing builds, but
generally speaking, having a failing build is not a big issue for me -
either you can fix it in-time (1 or 2 days) or if it's a no-brainer somebody
will fix it for you.
As I did a lot of sonar fixes recently, I'd like to encourage you to have a
look at sonar [1] and fix issues when you already edit a certain class.
Even more comfortable is the sonar eclipse plugin [2] - it will highlight
the problematic lines.
Although the plugin doesn't seem to process the results of our sonar
instance, it will run a sonar check on it's own, when you click "SonarQube
-> Analyze" on the project.
Andi
[1] https://analysis.apache.org/dashboard/index/org.apache.poi:poi-parent
[2] http://docs.sonarqube.org/display/SONAR/Installing+SonarQube+in+Eclipse
--
View this message in context: http://apache-poi.1045710.n5.nabble.com/Running-tests-before-commit-tp5720496p5720514.html
Sent from the POI - Dev mailing list archive at Nabble.com.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@poi.apache.org
For additional commands, e-mail: dev-help@poi.apache.org