[GitHub] jkosh44 commented on a change in pull request #975: [WIP] Issue 722

[GitBox <gi...@apache.org>]

jkosh44 commented on a change in pull request #975: [WIP] Issue 722
URL: https://github.com/apache/fluo/pull/975#discussion_r155544636
 
 

 ##########
 File path: modules/core/src/main/java/org/apache/fluo/core/oracle/OracleClient.java
 ##########
 @@ -73,7 +74,8 @@
   private static final class TimeRequest implements Callable<Stamp> {
     CountDownLatch cdl = new CountDownLatch(1);
     AtomicReference<Stamp> stampRef = new AtomicReference<>();
-    ListenableFutureTask<Stamp> lf = null;
+    // ListenableFutureTask<Stamp> lf = null;
+    CompletableFuture<Stamp> cf = null;
 
     @Override
     public Stamp call() throws Exception {
 
 Review comment:
   Yes I think you're right. The only reason I see that TimeRequest implemented Callable was so we could create a ListenableFutureTask with it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services