You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Dinesh Joshi (JIRA)" <ji...@apache.org> on 2018/11/27 19:09:00 UTC
[jira] [Commented] (CASSANDRA-14589)
CommitLogReplayer.handleReplayError swallows stack traces
[ https://issues.apache.org/jira/browse/CASSANDRA-14589?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16700882#comment-16700882 ]
Dinesh Joshi commented on CASSANDRA-14589:
------------------------------------------
This looks good. Just a minor whitespace issue [CommitLogReplayer.java#L411|https://github.com/apache/cassandra/compare/trunk...belliottsmith:CASSANDRA-14589-3.0#diff-348a1347dacf897385fb0a97116a1b5eR411] that you can fix on commit. +1.
> CommitLogReplayer.handleReplayError swallows stack traces
> ----------------------------------------------------------
>
> Key: CASSANDRA-14589
> URL: https://issues.apache.org/jira/browse/CASSANDRA-14589
> Project: Cassandra
> Issue Type: Bug
> Components: Observability
> Reporter: Benedict
> Assignee: Benedict
> Priority: Minor
> Fix For: 3.0.x
>
>
> handleReplayError does not accept an explicit Throwable parameter, so callers only integrate the exception’s message text into the log entry. This means a loss of debug information for operators.
> Note, this was fixed by CASSANDRA-8844 for 3.x+, only 3.0.x is affected.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@cassandra.apache.org
For additional commands, e-mail: commits-help@cassandra.apache.org