Re: Review Request: BOOKKEEPER-71 hedwig c++ client does not build.

[Sijie Guo <gu...@gmail.com>]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2446/#review2848
-----------------------------------------------------------


most is ok for me.

there are two suggestions:

1) separate cppunit DEPS. since only test need cppunit, library doesn't.

configure.ac

-PKG_CHECK_MODULES([DEPS], [liblog4cxx protobuf cppunit])
+PKG_CHECK_MODULES([DEPS], [liglog4cxx protobuf])
+PKG_CHECK_MODULES([TESTDEPS], [cppunit])

add TESTDEPS_LIBS only in test/Makefile.am .

2) cpp client can't build in gcc 3.4.0, since there is no tr1 library.

I suggested that change the headers which using tr1 libary as below.

+#ifdef HAVE_TR1
#include <tr1/memory>
+#else
+#include <boost/tr1/memory.hpp>
+#endif

then checking tr1 library in configure.ac

+AC_CHECK_HEADER(tr1/unordered_map, [AC_DEFINE([HAVE_TR1],[],["Have tr1"])],[])

- Sijie


On 2011-10-19 14:44:23, Ivan Kelly wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/2446/
> -----------------------------------------------------------
> 
> (Updated 2011-10-19 14:44:23)
> 
> 
> Review request for bookkeeper.
> 
> 
> Summary
> -------
> 
> The path to the protobuf spec is wrong in lib/Makefile.am.
> 
> I also cleaned up the tests, and made it use the provided scripts to stop and start bookkeeper and hedwig daemons.
> 
> 
> This addresses bug BOOKKEEPER-71.
>     https://issues.apache.org/jira/browse/BOOKKEEPER-71
> 
> 
> Diffs
> -----
> 
>   hedwig-server/src/test/java/org/apache/hedwig/ServerControlDaemon.java 14de705 
>   hedwig-client/src/main/cpp/test/util.h 2d92244 
>   hedwig-server/src/test/java/org/apache/hedwig/ServerControl.java be64f93 
>   hedwig-client/src/main/cpp/test/subscribetest.cpp 41da339 
>   hedwig-client/src/main/cpp/test/servercontrol.cpp 49696b7 
>   hedwig-client/src/main/cpp/test/servercontrol.h cac09e6 
>   hedwig-client/src/main/cpp/test/pubsubtest.cpp c0feade 
>   hedwig-client/src/main/cpp/test/main.cpp ef9190e 
>   hedwig-client/src/main/cpp/test/publishtest.cpp 95599d7 
>   hedwig-client/src/main/cpp/test/Makefile.am 84db87f 
>   hedwig-client/src/main/cpp/scripts/tester.sh c288076 
>   hedwig-client/src/main/cpp/scripts/network-delays.sh f566098 
>   hedwig-client/src/main/cpp/scripts/server-control.sh fa7f1c1 
>   hedwig-client/src/main/cpp/lib/Makefile.am 9a53138 
>   hedwig-client/src/main/cpp/README PRE-CREATION 
>   hedwig-client/src/main/cpp/config.h.in 19266b3 
> 
> Diff: https://reviews.apache.org/r/2446/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Ivan
> 
>