You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@httpd.apache.org by André Malo <nd...@perlig.de> on 2014/01/13 19:18:01 UTC

Re: svn commit: r1557641 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h modules/mappers/mod_dir.c modules/mappers/mod_rewrite.c modules/mappers/mod_rewrite.h

* covener@apache.org wrote:

> Author: covener
> Date: Mon Jan 13 01:51:58 2014
> New Revision: 1557641
>
> URL: http://svn.apache.org/r1557641
> Log:
> don't search for directory indexes/directoryslashes if a URL is in the
> middle of being rewritten [in per-dir context]. PR53929
>
>
> Modified: httpd/httpd/trunk/modules/mappers/mod_rewrite.h
> URL:
> http://svn.apache.org/viewvc/httpd/httpd/trunk/modules/mappers/mod_rewrit
>e.h?rev=1557641&r1=1557640&r2=1557641&view=diff
> =========================================================================
>===== --- httpd/httpd/trunk/modules/mappers/mod_rewrite.h (original)
> +++ httpd/httpd/trunk/modules/mappers/mod_rewrite.h Mon Jan 13 01:51:58
> 2014 @@ -29,6 +29,8 @@
>  #include "apr_optional.h"
>  #include "httpd.h"
>
> +#define REDIRECT_HANDLER_NAME "redirect-handler"
> +
>  /* rewrite map function prototype */
>  typedef char *(rewrite_mapfunc_t)(request_rec *r, char *key);

Should it be prefixed (e.g. with REWRITE_)?

And maybe the handler name, too? (this one trunk only).

nd
-- 
Wer sein Wissen nicht teilen will, besitzt wahrscheinlich zu wenig davon.
  -- Unbekannt

Re: svn commit: r1557641 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h modules/mappers/mod_dir.c modules/mappers/mod_rewrite.c modules/mappers/mod_rewrite.h

Posted by Eric Covener <co...@gmail.com>.
r1559394 -- thanks for review

On Mon, Jan 13, 2014 at 2:41 PM, Eric Covener <co...@gmail.com> wrote:
>>
>> Should it be prefixed (e.g. with REWRITE_)?
>>
>> And maybe the handler name, too? (this one trunk only).
>
> makes sense, will revisit soon.



-- 
Eric Covener
covener@gmail.com

Re: svn commit: r1557641 - in /httpd/httpd/trunk: CHANGES include/ap_mmn.h modules/mappers/mod_dir.c modules/mappers/mod_rewrite.c modules/mappers/mod_rewrite.h

Posted by Eric Covener <co...@gmail.com>.
>
> Should it be prefixed (e.g. with REWRITE_)?
>
> And maybe the handler name, too? (this one trunk only).

makes sense, will revisit soon.