You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "mertdotcc (via GitHub)" <gi...@apache.org> on 2023/03/30 22:03:49 UTC
[GitHub] [camel-k] mertdotcc opened a new issue, #4205: Bring in the option to have more verbose IntegrationKit names
mertdotcc opened a new issue, #4205:
URL: https://github.com/apache/camel-k/issues/4205
Creating this issue as per the discussion at [#4172](https://github.com/apache/camel-k/issues/4172).
[This](https://github.com/apache/camel-k/issues/4172#issuecomment-1486793595) pretty much summarizes my initial idea for this ticket.
Open to discussions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on issue #4205: Bring in the option to have more verbose IntegrationKit names
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on issue #4205:
URL: https://github.com/apache/camel-k/issues/4205#issuecomment-1493851111
For the reason in [this](https://github.com/apache/camel-k/issues/4205#issuecomment-1491456615) comment, I would really avoid using any integration name to name a context as it would be misleading. An integration kit is meant to be independent from the integration it has been created from otherwise it would become useless.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] mertdotcc commented on issue #4205: Bring in the option to have more verbose IntegrationKit names
Posted by "mertdotcc (via GitHub)" <gi...@apache.org>.
mertdotcc commented on issue #4205:
URL: https://github.com/apache/camel-k/issues/4205#issuecomment-1493827271
+1 for the `alias`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez closed issue #4205: Bring in the option to have more verbose IntegrationKit names
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez closed issue #4205: Bring in the option to have more verbose IntegrationKit names
URL: https://github.com/apache/camel-k/issues/4205
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] lburgazzoli commented on issue #4205: Bring in the option to have more verbose IntegrationKit names
Posted by "lburgazzoli (via GitHub)" <gi...@apache.org>.
lburgazzoli commented on issue #4205:
URL: https://github.com/apache/camel-k/issues/4205#issuecomment-1491456615
Please note that the integration kit is meant to be shareable among integrations and also survives the deletion of an integration so I would really try to avoid adding any prefix linked to the integration. If you want a kit per integration, then better to add an option to create a non shareable and garbage collectable kit (this happens already when you run an integration with a specific container image)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #4205: Bring in the option to have more verbose IntegrationKit names
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #4205:
URL: https://github.com/apache/camel-k/issues/4205#issuecomment-1491449274
It could be an idea. Right now, this is a kind of convention shared among `IntegrationKit` and `Build`, so, anything changed in one place may influence the other.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] mertdotcc commented on issue #4205: Bring in the option to have more verbose IntegrationKit names
Posted by "mertdotcc (via GitHub)" <gi...@apache.org>.
mertdotcc commented on issue #4205:
URL: https://github.com/apache/camel-k/issues/4205#issuecomment-1493845660
Another idea: instead of having kit names with alphanumeric/UUID-like suffixes (`kit-cge4mdsvri59ugp5v2hg` - `kit-cge5i2kvri59ugp5v2i0`), having them in simple version-like names. Example: `messaging-integration-kit-v1`, `booking-integration-kit-v4` etc.
What do you guys think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #4205: Bring in the option to have more verbose IntegrationKit names
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #4205:
URL: https://github.com/apache/camel-k/issues/4205#issuecomment-1493857787
Yes, as @lburgazzoli is mentioning, the idea of the Kits is to have them reusable. The name is something meaningful to the operator and should not be altered. That was the reason why I proposed the possibility to use an alias in order to easily identify the Kit but without altering the logic required by the operator.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] squakez commented on issue #4205: Bring in the option to have more verbose IntegrationKit names
Posted by "squakez (via GitHub)" <gi...@apache.org>.
squakez commented on issue #4205:
URL: https://github.com/apache/camel-k/issues/4205#issuecomment-1493821549
What probably makes sense for this feature is to introduce a field (or even an annotation) called `alias`. That one can be used by the final user to give a name to the Kit and it can be easily exposed by kube builder in CLIs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-k] mertdotcc commented on issue #4205: Bring in the option to have more verbose IntegrationKit names
Posted by "mertdotcc (via GitHub)" <gi...@apache.org>.
mertdotcc commented on issue #4205:
URL: https://github.com/apache/camel-k/issues/4205#issuecomment-1493860701
Okay, I see. Makes sense. Disregarded the fact that the kits are re-usable among different integrations. Then it's a super +1 from me for `alias`. 🙂
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org