You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/04/13 11:30:27 UTC
[GitHub] [apisix-ingress-controller] batman-ezio opened a new pull request #367: feature: add golangci-lint
batman-ezio opened a new pull request #367:
URL: https://github.com/apache/apisix-ingress-controller/pull/367
Please answer these questions before submitting a pull request
- Why submit this pull request?
- [ ] Bugfix
- [ ] New feature provided
- [ ] Improve performance
- [ ] Backport patches
- Related issues
___
### Bugfix
- Description
- How to fix?
___
### New feature or improvement
- Describe the details and related test reports.
___
### Backport patches
- Why need to backport?
- Source branch
- Related commits and pull requests
- Target branch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #367: feature: add golangci-lint
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #367:
URL: https://github.com/apache/apisix-ingress-controller/pull/367#issuecomment-819143839
> @tokers after setup , I see there's some errors in actions, may need some permission settings
> 
Sigh, Only official or Apache itself's actions are allowed to use for now. You may try to download golangci-lint and execute in shell.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers edited a comment on pull request #367: feat: add golangci-lint
Posted by GitBox <gi...@apache.org>.
tokers edited a comment on pull request #367:
URL: https://github.com/apache/apisix-ingress-controller/pull/367#issuecomment-834950562
Solved by another PR #419, now closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #367: feat: add golangci-lint
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #367:
URL: https://github.com/apache/apisix-ingress-controller/pull/367#issuecomment-834950562
Solved by another PR #419 , now closing it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] Yiyiyimu commented on pull request #367: feature: add golangci-lint
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #367:
URL: https://github.com/apache/apisix-ingress-controller/pull/367#issuecomment-819988958
@batman-ezio Or you could try to add the action repo as a submodule, recursively checkout, and then use it as the Action source. See [Apache Recommended Way](https://cwiki.apache.org/confluence/display/BUILDS/GitHub+Actions+status#GitHubActionsstatus-Security)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #367: feat: add golangci-lint
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #367:
URL: https://github.com/apache/apisix-ingress-controller/pull/367#issuecomment-821921676
@batman-ezio Hi, it seems that you don't actually run the `make lint` command but just installing the golangci-lint.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers commented on pull request #367: feature: add golangci-lint
Posted by GitBox <gi...@apache.org>.
tokers commented on pull request #367:
URL: https://github.com/apache/apisix-ingress-controller/pull/367#issuecomment-819962985
@batman-ezio Refer to https://github.com/apache/apisix-dashboard/blob/master/.github/workflows/go-lint.yml for some details.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] tokers closed pull request #367: feat: add golangci-lint
Posted by GitBox <gi...@apache.org>.
tokers closed pull request #367:
URL: https://github.com/apache/apisix-ingress-controller/pull/367
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-ingress-controller] batman-ezio commented on pull request #367: feature: add golangci-lint
Posted by GitBox <gi...@apache.org>.
batman-ezio commented on pull request #367:
URL: https://github.com/apache/apisix-ingress-controller/pull/367#issuecomment-819098333
@tokers after setup , I see there's some errors in actions, may need some permission settings
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org