You are viewing a plain text version of this content. The canonical link for it is here.
Posted to cvs@httpd.apache.org by Mark J Cox <mj...@hyperreal.com> on 1996/07/04 15:02:02 UTC
cvs commit: apache/src mod_cookies.c
mjc 96/07/04 06:02:01
Modified: src mod_cookies.c
Log:
Missing "else" caused two lines per Cookie to be logged
Revision Changes Path
1.10 +11 -12 apache/src/mod_cookies.c
Index: mod_cookies.c
===================================================================
RCS file: /export/home/cvs/apache/src/mod_cookies.c,v
retrieving revision 1.9
retrieving revision 1.10
diff -C3 -r1.9 -r1.10
*** mod_cookies.c 1996/05/24 13:10:14 1.9
--- mod_cookies.c 1996/07/04 13:01:59 1.10
***************
*** 86,103 ****
*
* Mark Cox, mark@ukweb.com, http://www.ukweb.com/~mark/, 6 July 95
*
! * 6.12.95 MJC Now be more friendly. Allow our cookies to overlap with
! * others the site may be using. Use a more descriptive
! * cookie name.
! *
! * 18.3.96 MJC Generate cookies for EVERY request no matter what the
! * browser. We never know when a new browser writer will
! * add cookie support.
! *
! * 96/03/31 -JimC Allow the log to be sent to a pipe. Copies the relevant
! * code from mod_log_agent.c.
! *
! * 24.5.96 MJC Improved documentation after receiving comments from users
*/
#include "httpd.h"
--- 86,101 ----
*
* Mark Cox, mark@ukweb.com, http://www.ukweb.com/~mark/, 6 July 95
*
! * 6.12.95 MJC Now be more friendly. Allow our cookies to overlap with
! * others the site may be using. Use a more descriptive
! * cookie name.
! * 18.3.96 MJC Generate cookies for EVERY request no matter what the
! * browser. We never know when a new browser writer will
! * add cookie support.
! * 31.3.95 JimC Allow the log to be sent to a pipe. Copies the relevant
! * code from mod_log_agent.c.
! * 24.5.96 MJC Improved documentation after receiving comments from users
! * 4.7.96 MJC Bug, "else" missing since February caused logging twice
*/
#include "httpd.h"
***************
*** 269,274 ****
--- 267,273 ----
if (r->status != -1)
sprintf(&tstr[strlen(tstr)], "%c%02ld%02ld] %d\n", sign, timz/3600,
timz%3600, r->status);
+ else
sprintf(&tstr[strlen(tstr)], "%c%02ld%02ld] -\n", sign, timz/3600,
timz%3600);
Re: cvs commit: apache/src mod_cookies.c
Posted by Brian Behlendorf <br...@organic.com>.
On Thu, 4 Jul 1996, Paul Richards wrote:
> Mark J. Cox writes:
> > ! * add cookie support.
> > ! * 31.3.95 JimC Allow the log to be sent to a pipe. Copies the relevant
> > ! * code from mod_log_agent.c.
> > ! * 24.5.96 MJC Improved documentation after receiving comments from users
> > ! * 4.7.96 MJC Bug, "else" missing since February caused logging twice
> > */
>
> Can we delete log information from inside files please? It should all go in
> the cvs logs and not clutter up the files themselves.
>
> The best way to do this is to cut and paste the log info into the commit
> message when you remove it and then it all gets added to the cvs log
> info so you can see it using the normal cvs commands.
I like the tight binding this provides, mostly because it allows
non-Apache-listmembers to see what's changed over time. Perhaps old ones
can be "rolled off" in any place they get too numerous.
Brian
--=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=-=--
brian@organic.com www.apache.org hyperreal.com http://www.organic.com/JOBS
cvs commit: apache/src mod_cookies.c
Posted by Paul Richards <p....@elsevier.co.uk>.
Mark J. Cox writes:
> ! * add cookie support.
> ! * 31.3.95 JimC Allow the log to be sent to a pipe. Copies the relevant
> ! * code from mod_log_agent.c.
> ! * 24.5.96 MJC Improved documentation after receiving comments from users
> ! * 4.7.96 MJC Bug, "else" missing since February caused logging twice
> */
Can we delete log information from inside files please? It should all go in
the cvs logs and not clutter up the files themselves.
The best way to do this is to cut and paste the log info into the commit
message when you remove it and then it all gets added to the cvs log
info so you can see it using the normal cvs commands.
Also, we should add ID strings to all the files sometime soon as well.