You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@mesos.apache.org by Jiang Yan Xu <ya...@jxu.me> on 2014/08/13 23:10:45 UTC

Review Request 24667: Added a user doc for framework rate limiting.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24667/
-----------------------------------------------------------

Review request for mesos and Vinod Kone.


Bugs: MESOS-1683
    https://issues.apache.org/jira/browse/MESOS-1683


Repository: mesos-git


Description
-------

See summary.


Diffs
-----

  docs/framework-rate-limiting.md PRE-CREATION 

Diff: https://reviews.apache.org/r/24667/diff/


Testing
-------

Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9


Thanks,

Jiang Yan Xu

Re: Review Request 24667: Added a user doc for framework rate limiting.

Posted by Jiang Yan Xu <ya...@jxu.me>.


> On Aug. 13, 2014, 4:44 p.m., Vinod Kone wrote:
> > docs/framework-rate-limiting.md, line 61
> > <https://reviews.apache.org/r/24667/diff/1/?file=659575#file659575line61>
> >
> >     what do you mean by "nature of the frameworks"? do you mean "messages generated by the frameworks"?

Removed these sentences.


- Jiang Yan


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24667/#review50526
-----------------------------------------------------------


On Aug. 14, 2014, 3:16 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24667/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 3:16 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1683
>     https://issues.apache.org/jira/browse/MESOS-1683
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/framework-rate-limiting.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24667/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 24667: Added a user doc for framework rate limiting.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24667/#review50526
-----------------------------------------------------------



docs/framework-rate-limiting.md
<https://reviews.apache.org/r/24667/#comment88388>

    s/the this/this/
    
    s/that it crashes/causing the master to OOM/



docs/framework-rate-limiting.md
<https://reviews.apache.org/r/24667/#comment88389>

    not sure I understand the statement in brackets. can you rephrase maybe?



docs/framework-rate-limiting.md
<https://reviews.apache.org/r/24667/#comment88390>

    s/turns/terms/



docs/framework-rate-limiting.md
<https://reviews.apache.org/r/24667/#comment88391>

    what do you mean by "nature of the frameworks"? do you mean "messages generated by the frameworks"?



docs/framework-rate-limiting.md
<https://reviews.apache.org/r/24667/#comment88392>

    by "its messages" you mean master's or frameworks'? i guess the latter? i'm still a bit unclear on what the recommendation is here. can you expand on the comment?


- Vinod Kone


On Aug. 13, 2014, 9:10 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24667/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 9:10 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1683
>     https://issues.apache.org/jira/browse/MESOS-1683
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/framework-rate-limiting.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24667/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 24667: Added a user doc for framework rate limiting.

Posted by Vinod Kone <vi...@gmail.com>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24667/#review50659
-----------------------------------------------------------

Ship it!



docs/framework-rate-limiting.md
<https://reviews.apache.org/r/24667/#comment88511>

    s/implicitly/implicit/



docs/framework-rate-limiting.md
<https://reviews.apache.org/r/24667/#comment88513>

    s/temporarily/temporary/


- Vinod Kone


On Aug. 14, 2014, 10:16 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24667/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 10:16 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1683
>     https://issues.apache.org/jira/browse/MESOS-1683
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/framework-rate-limiting.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24667/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 24667: Added a user doc for framework rate limiting.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24667/#review50697
-----------------------------------------------------------


Bad patch!

Reviews applied: [24667]

Failed command: git apply --index 24667.patch

Error:
 error: docs/framework-rate-limiting.md: already exists in index

- Mesos ReviewBot


On Aug. 14, 2014, 10:16 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24667/
> -----------------------------------------------------------
> 
> (Updated Aug. 14, 2014, 10:16 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1683
>     https://issues.apache.org/jira/browse/MESOS-1683
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/framework-rate-limiting.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24667/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>

Re: Review Request 24667: Added a user doc for framework rate limiting.

Posted by Jiang Yan Xu <ya...@jxu.me>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24667/
-----------------------------------------------------------

(Updated Aug. 14, 2014, 3:16 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-1683
    https://issues.apache.org/jira/browse/MESOS-1683


Repository: mesos-git


Description
-------

See summary.


Diffs (updated)
-----

  docs/framework-rate-limiting.md PRE-CREATION 

Diff: https://reviews.apache.org/r/24667/diff/


Testing
-------

Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9


Thanks,

Jiang Yan Xu

Re: Review Request 24667: Added a user doc for framework rate limiting.

Posted by Mesos ReviewBot <de...@mesos.apache.org>.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/24667/#review50527
-----------------------------------------------------------


Patch looks great!

Reviews applied: [24667]

All tests passed.

- Mesos ReviewBot


On Aug. 13, 2014, 9:10 p.m., Jiang Yan Xu wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/24667/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2014, 9:10 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-1683
>     https://issues.apache.org/jira/browse/MESOS-1683
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> See summary.
> 
> 
> Diffs
> -----
> 
>   docs/framework-rate-limiting.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/24667/diff/
> 
> 
> Testing
> -------
> 
> Rendered version: https://gist.github.com/xujyan/d2bdd2052fac489fb1a9
> 
> 
> Thanks,
> 
> Jiang Yan Xu
> 
>