You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org> on 2021/04/08 03:57:11 UTC
[Impala-ASF-CR] IMPALA-10643: Allow the inclusion of jetty-client
Fang-Yu Rao has uploaded this change for review. ( http://gerrit.cloudera.org:8080/17287
Change subject: IMPALA-10643: Allow the inclusion of jetty-client
......................................................................
IMPALA-10643: Allow the inclusion of jetty-client
We excluded all artifacts under the group of org.eclipse.jetty for
ranger-plugins-audit when bumping up CDP_BUILD_NUMBER to 4493826, which
is too stringent in that the artifact of jetty-client is actually
required by ranger-plugins-audit. Excluding jetty-client would thus
result in a NoClassDefFoundError at runtime. This patch removes the
block that excluded all artifacts of org.eclipse.jetty when the
dependency of ranger-plugins-audit is added, which allows
ranger-plugins-audit to pull in jetty-client, which in turn pulls in
jetty-http and jetty-io. In this regard, we also add these three
artifacts as allowed dependencies because all artifacts under
org.eclipse.jetty are banned in the section of bannedDependencies.
Testing:
- Verified in a local development environment that Impala could build
and that jetty-client-9.4.31.v20200723.jar is indeed on the class
path in fe/target/build-classpath.txt.
Change-Id: I9087b7e6866f1500c66f42a74b3f8619e82c3bda
---
M fe/pom.xml
1 file changed, 8 insertions(+), 4 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/87/17287/1
--
To view, visit http://gerrit.cloudera.org:8080/17287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I9087b7e6866f1500c66f42a74b3f8619e82c3bda
Gerrit-Change-Number: 17287
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
[Impala-ASF-CR] IMPALA-10643: Allow the inclusion of jetty-client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17287 )
Change subject: IMPALA-10643: Allow the inclusion of jetty-client
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/17287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9087b7e6866f1500c66f42a74b3f8619e82c3bda
Gerrit-Change-Number: 17287
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Apr 2021 21:31:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10643: Allow the inclusion of jetty-client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17287 )
Change subject: IMPALA-10643: Allow the inclusion of jetty-client
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/17287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9087b7e6866f1500c66f42a74b3f8619e82c3bda
Gerrit-Change-Number: 17287
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Apr 2021 15:45:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10643: Allow the inclusion of jetty-client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/17287 )
Change subject: IMPALA-10643: Allow the inclusion of jetty-client
......................................................................
IMPALA-10643: Allow the inclusion of jetty-client
We excluded all artifacts under the group of org.eclipse.jetty for
ranger-plugins-audit when bumping up CDP_BUILD_NUMBER to 4493826, which
is too stringent in that the artifact of jetty-client is actually
required by ranger-plugins-audit. Excluding jetty-client would thus
result in a NoClassDefFoundError at runtime. This patch removes the
block that excluded all artifacts of org.eclipse.jetty when the
dependency of ranger-plugins-audit is added, which allows
ranger-plugins-audit to pull in jetty-client, which in turn pulls in
jetty-http and jetty-io. In this regard, we also add these three
artifacts as allowed dependencies because all artifacts under
org.eclipse.jetty are banned in the section of bannedDependencies.
Testing:
- Verified in a local development environment that Impala could build
and that jetty-client-9.4.31.v20200723.jar is indeed on the class
path in fe/target/build-classpath.txt.
Change-Id: I9087b7e6866f1500c66f42a74b3f8619e82c3bda
Reviewed-on: http://gerrit.cloudera.org:8080/17287
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/pom.xml
1 file changed, 8 insertions(+), 4 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/17287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I9087b7e6866f1500c66f42a74b3f8619e82c3bda
Gerrit-Change-Number: 17287
Gerrit-PatchSet: 3
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
[Impala-ASF-CR] IMPALA-10643: Allow the inclusion of jetty-client
Posted by "Fang-Yu Rao (Code Review)" <ge...@cloudera.org>.
Fang-Yu Rao has posted comments on this change. ( http://gerrit.cloudera.org:8080/17287 )
Change subject: IMPALA-10643: Allow the inclusion of jetty-client
......................................................................
Patch Set 1:
Hi Joe, please review this patch and let me know if there is any suggestion or comment. Thank you very much!
--
To view, visit http://gerrit.cloudera.org:8080/17287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9087b7e6866f1500c66f42a74b3f8619e82c3bda
Gerrit-Change-Number: 17287
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 03:57:47 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10643: Allow the inclusion of jetty-client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17287 )
Change subject: IMPALA-10643: Allow the inclusion of jetty-client
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/7058/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/17287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9087b7e6866f1500c66f42a74b3f8619e82c3bda
Gerrit-Change-Number: 17287
Gerrit-PatchSet: 2
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Apr 2021 15:45:01 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10643: Allow the inclusion of jetty-client
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/17287 )
Change subject: IMPALA-10643: Allow the inclusion of jetty-client
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/8523/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/17287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9087b7e6866f1500c66f42a74b3f8619e82c3bda
Gerrit-Change-Number: 17287
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 04:17:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-10643: Allow the inclusion of jetty-client
Posted by "Joe McDonnell (Code Review)" <ge...@cloudera.org>.
Joe McDonnell has posted comments on this change. ( http://gerrit.cloudera.org:8080/17287 )
Change subject: IMPALA-10643: Allow the inclusion of jetty-client
......................................................................
Patch Set 1: Code-Review+2
Thanks for fixing this! Looks good.
--
To view, visit http://gerrit.cloudera.org:8080/17287
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I9087b7e6866f1500c66f42a74b3f8619e82c3bda
Gerrit-Change-Number: 17287
Gerrit-PatchSet: 1
Gerrit-Owner: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Fang-Yu Rao <fa...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Joe McDonnell <jo...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Apr 2021 16:41:23 +0000
Gerrit-HasComments: No