You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@zeppelin.apache.org by mo...@apache.org on 2017/11/30 17:01:25 UTC
zeppelin git commit: ZEPPELIN-2984: allow enter from username
Repository: zeppelin
Updated Branches:
refs/heads/master 83164c843 -> 0d1dab2ab
ZEPPELIN-2984: allow enter from username
### What is this PR for?
Allow an "Enter" keypress in the username field during login
### What type of PR is it?
Improvement
### Todos
* N/A
### What is the Jira issue?
* https://issues.apache.org/jira/browse/ZEPPELIN-2984
### How should this be tested?
* Pull up login screen. Fill in username and password. Click in username field.
Press enter. We would expect the login handler to be called.
* Pull up login screen. Fill in username and password. Press enter (while still
in password field). We would expect the login handler to be called just as
before.
* Alternatively, use a password manager (e.g. LastPass). Save the password.
Pull up the login screen. Press Enter. We would expect the login handler to be
called.
### Screenshots (if appropriate)
### Questions:
* Does the licenses files need update? No
* Is there breaking changes for older versions? No
* Does this needs documentation? No
Author: Gabe Fernando <ge...@gmail.com>
Closes #2616 from gef756/dev-login-enter and squashes the following commits:
301d398 [Gabe Fernando] MRG: Merge remote-tracking branch 'origin/master' into dev-login-enter
2a1865a [Gabe Fernando] (ZEPPELIN-2984) ENH: allow enter from username
Project: http://git-wip-us.apache.org/repos/asf/zeppelin/repo
Commit: http://git-wip-us.apache.org/repos/asf/zeppelin/commit/0d1dab2a
Tree: http://git-wip-us.apache.org/repos/asf/zeppelin/tree/0d1dab2a
Diff: http://git-wip-us.apache.org/repos/asf/zeppelin/diff/0d1dab2a
Branch: refs/heads/master
Commit: 0d1dab2ab25e85b49b6a392e1bb5995ca691215c
Parents: 83164c8
Author: Gabe Fernando <ge...@gmail.com>
Authored: Fri Nov 24 14:00:02 2017 -0500
Committer: Lee moon soo <mo...@apache.org>
Committed: Thu Nov 30 09:01:21 2017 -0800
----------------------------------------------------------------------
zeppelin-web/src/components/login/login.html | 1 +
1 file changed, 1 insertion(+)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/zeppelin/blob/0d1dab2a/zeppelin-web/src/components/login/login.html
----------------------------------------------------------------------
diff --git a/zeppelin-web/src/components/login/login.html b/zeppelin-web/src/components/login/login.html
index d4a94a6..fd98bc8 100644
--- a/zeppelin-web/src/components/login/login.html
+++ b/zeppelin-web/src/components/login/login.html
@@ -29,6 +29,7 @@ limitations under the License.
<div class="form-group">
<label for="userName">User Name</label>
<input placeholder="User Name" type="text" class="form-control" id="userName"
+ ng-enter="login()"
ng-keypress="loginParams.errorText = ''"
ng-model="loginParams.userName" />
</div>