You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/12/24 10:36:40 UTC

[GitHub] [shardingsphere] menghaoranss opened a new pull request #8757: Add global lock for jdbc

menghaoranss opened a new pull request #8757:
URL: https://github.com/apache/shardingsphere/pull/8757


   For #8060 .
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io edited a comment on pull request #8757: Add global lock for jdbc

Posted by GitBox <gi...@apache.org>.
codecov-io edited a comment on pull request #8757:
URL: https://github.com/apache/shardingsphere/pull/8757#issuecomment-751136843


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=h1) Report
   > Merging [#8757](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=desc) (24e22a3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ab45b9dba391d6bd904ff8da6b596f1d1299a241?el=desc) (ab45b9d) will **decrease** coverage by `0.26%`.
   > The diff coverage is `41.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8757/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8757      +/-   ##
   ============================================
   - Coverage     70.91%   70.64%   -0.27%     
   - Complexity      624      626       +2     
   ============================================
     Files          1597     1588       -9     
     Lines         25408    25396      -12     
     Branches       4439     4446       +7     
   ============================================
   - Hits          18017    17940      -77     
   - Misses         6199     6259      +60     
   - Partials       1192     1197       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...overnance/internal/state/impl/LockDriverState.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWdvdmVybmFuY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9nb3Zlcm5hbmNlL2ludGVybmFsL3N0YXRlL2ltcGwvTG9ja0RyaXZlclN0YXRlLmphdmE=) | `10.00% <0.00%> (-40.00%)` | `1.00 <0.00> (ø)` | |
   | [...dingsphere/driver/executor/DriverJDBCExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9Ecml2ZXJKREJDRXhlY3V0b3IuamF2YQ==) | `37.20% <38.46%> (-6.27%)` | `0.00 <0.00> (ø)` | |
   | [...phere/governance/core/registry/RegistryCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9SZWdpc3RyeUNlbnRlci5qYXZh) | `55.26% <100.00%> (+1.20%)` | `0.00 <0.00> (ø)` | |
   | [...jdbc/core/datasource/ShardingSphereDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvZGF0YXNvdXJjZS9TaGFyZGluZ1NwaGVyZURhdGFTb3VyY2UuamF2YQ==) | `91.66% <100.00%> (+0.36%)` | `0.00 <0.00> (ø)` | |
   | [...datasource/GovernanceShardingSphereDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWdvdmVybmFuY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9nb3Zlcm5hbmNlL2ludGVybmFsL2RhdGFzb3VyY2UvR292ZXJuYW5jZVNoYXJkaW5nU3BoZXJlRGF0YVNvdXJjZS5qYXZh) | `96.36% <100.00%> (+0.36%)` | `0.00 <0.00> (ø)` | |
   | [...rdingsphere/agent/core/spi/AgentServiceLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9zcGkvQWdlbnRTZXJ2aWNlTG9hZGVyLmphdmE=) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (ø%)` | |
   | [...ngsphere/agent/core/spi/AgentTypedSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9zcGkvQWdlbnRUeXBlZFNQSVJlZ2lzdHJ5LmphdmE=) | `0.00% <0.00%> (-54.55%)` | `0.00% <0.00%> (ø%)` | |
   | [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `32.72% <0.00%> (-27.28%)` | `0.00% <0.00%> (ø%)` | |
   | [...driver/executor/callback/ExecuteQueryCallback.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9jYWxsYmFjay9FeGVjdXRlUXVlcnlDYWxsYmFjay5qYXZh) | `83.33% <0.00%> (-16.67%)` | `1.00% <0.00%> (ø%)` | |
   | [...sition/resume/AbstractResumeBreakPointManager.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vcmVzdW1lL0Fic3RyYWN0UmVzdW1lQnJlYWtQb2ludE1hbmFnZXIuamF2YQ==) | `91.30% <0.00%> (-8.70%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [62 more](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=footer). Last update [ab45b9d...24e22a3](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] menghaoranss closed pull request #8757: Add global lock for jdbc

Posted by GitBox <gi...@apache.org>.
menghaoranss closed pull request #8757:
URL: https://github.com/apache/shardingsphere/pull/8757


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] codecov-io commented on pull request #8757: Add global lock for jdbc

Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #8757:
URL: https://github.com/apache/shardingsphere/pull/8757#issuecomment-751136843


   # [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=h1) Report
   > Merging [#8757](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=desc) (24e22a3) into [master](https://codecov.io/gh/apache/shardingsphere/commit/ab45b9dba391d6bd904ff8da6b596f1d1299a241?el=desc) (ab45b9d) will **decrease** coverage by `0.26%`.
   > The diff coverage is `41.46%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/shardingsphere/pull/8757/graphs/tree.svg?width=650&height=150&src=pr&token=ZvlXpWa7so)](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #8757      +/-   ##
   ============================================
   - Coverage     70.91%   70.64%   -0.27%     
   - Complexity      624      626       +2     
   ============================================
     Files          1597     1588       -9     
     Lines         25408    25396      -12     
     Branches       4439     4446       +7     
   ============================================
   - Hits          18017    17940      -77     
   - Misses         6199     6259      +60     
   - Partials       1192     1197       +5     
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...overnance/internal/state/impl/LockDriverState.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWdvdmVybmFuY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9nb3Zlcm5hbmNlL2ludGVybmFsL3N0YXRlL2ltcGwvTG9ja0RyaXZlclN0YXRlLmphdmE=) | `10.00% <0.00%> (-40.00%)` | `1.00 <0.00> (ø)` | |
   | [...dingsphere/driver/executor/DriverJDBCExecutor.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9Ecml2ZXJKREJDRXhlY3V0b3IuamF2YQ==) | `37.20% <38.46%> (-6.27%)` | `0.00 <0.00> (ø)` | |
   | [...phere/governance/core/registry/RegistryCenter.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtZ292ZXJuYW5jZS9zaGFyZGluZ3NwaGVyZS1nb3Zlcm5hbmNlLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2dvdmVybmFuY2UvY29yZS9yZWdpc3RyeS9SZWdpc3RyeUNlbnRlci5qYXZh) | `55.26% <100.00%> (+1.20%)` | `0.00 <0.00> (ø)` | |
   | [...jdbc/core/datasource/ShardingSphereDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9qZGJjL2NvcmUvZGF0YXNvdXJjZS9TaGFyZGluZ1NwaGVyZURhdGFTb3VyY2UuamF2YQ==) | `91.66% <100.00%> (+0.36%)` | `0.00 <0.00> (ø)` | |
   | [...datasource/GovernanceShardingSphereDataSource.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWdvdmVybmFuY2Uvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9nb3Zlcm5hbmNlL2ludGVybmFsL2RhdGFzb3VyY2UvR292ZXJuYW5jZVNoYXJkaW5nU3BoZXJlRGF0YVNvdXJjZS5qYXZh) | `96.36% <100.00%> (+0.36%)` | `0.00 <0.00> (ø)` | |
   | [...rdingsphere/agent/core/spi/AgentServiceLoader.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9zcGkvQWdlbnRTZXJ2aWNlTG9hZGVyLmphdmE=) | `0.00% <0.00%> (-73.92%)` | `0.00% <0.00%> (ø%)` | |
   | [...ngsphere/agent/core/spi/AgentTypedSPIRegistry.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtYWdlbnQvc2hhcmRpbmdzcGhlcmUtYWdlbnQtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvc2hhcmRpbmdzcGhlcmUvYWdlbnQvY29yZS9zcGkvQWdlbnRUeXBlZFNQSVJlZ2lzdHJ5LmphdmE=) | `0.00% <0.00%> (-54.55%)` | `0.00% <0.00%> (ø%)` | |
   | [...re/scaling/core/schedule/ScalingTaskScheduler.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9zY2hlZHVsZS9TY2FsaW5nVGFza1NjaGVkdWxlci5qYXZh) | `32.72% <0.00%> (-27.28%)` | `0.00% <0.00%> (ø%)` | |
   | [...driver/executor/callback/ExecuteQueryCallback.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtamRiYy9zaGFyZGluZ3NwaGVyZS1qZGJjLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL2RyaXZlci9leGVjdXRvci9jYWxsYmFjay9FeGVjdXRlUXVlcnlDYWxsYmFjay5qYXZh) | `83.33% <0.00%> (-16.67%)` | `1.00% <0.00%> (ø%)` | |
   | [...sition/resume/AbstractResumeBreakPointManager.java](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree#diff-c2hhcmRpbmdzcGhlcmUtc2NhbGluZy9zaGFyZGluZ3NwaGVyZS1zY2FsaW5nLWNvcmUvc3JjL21haW4vamF2YS9vcmcvYXBhY2hlL3NoYXJkaW5nc3BoZXJlL3NjYWxpbmcvY29yZS9qb2IvcG9zaXRpb24vcmVzdW1lL0Fic3RyYWN0UmVzdW1lQnJlYWtQb2ludE1hbmFnZXIuamF2YQ==) | `91.30% <0.00%> (-8.70%)` | `0.00% <0.00%> (ø%)` | |
   | ... and [62 more](https://codecov.io/gh/apache/shardingsphere/pull/8757/diff?src=pr&el=tree-more) | |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=footer). Last update [ab45b9d...24e22a3](https://codecov.io/gh/apache/shardingsphere/pull/8757?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [shardingsphere] yu199195 merged pull request #8757: Add global lock for jdbc

Posted by GitBox <gi...@apache.org>.
yu199195 merged pull request #8757:
URL: https://github.com/apache/shardingsphere/pull/8757


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org