Re: svn commit: r1453531 - /commons/proper/fileupload/trunk/src/main/assembly/src.xml

[sebb <se...@gmail.com>]

On 6 March 2013 20:17,  <si...@apache.org> wrote:
> Author: simonetripodi
> Date: Wed Mar  6 20:17:47 2013
> New Revision: 1453531
>
> URL: http://svn.apache.org/r1453531
> Log:
> inverted logic: include basedir and exclude build/IDE dirs, in order to not manually maintain the list of files have to be kept in the archive

-1

Sorry, but this is not safe (as per discussions on ognl)

[Note also that the include list likely changes less frequently than
the exclude list...]

> Modified:
>     commons/proper/fileupload/trunk/src/main/assembly/src.xml
>
> Modified: commons/proper/fileupload/trunk/src/main/assembly/src.xml
> URL: http://svn.apache.org/viewvc/commons/proper/fileupload/trunk/src/main/assembly/src.xml?rev=1453531&r1=1453530&r2=1453531&view=diff
> ==============================================================================
> --- commons/proper/fileupload/trunk/src/main/assembly/src.xml (original)
> +++ commons/proper/fileupload/trunk/src/main/assembly/src.xml Wed Mar  6 20:17:47 2013
> @@ -26,18 +26,14 @@
>    <baseDirectory>${artifactId}-${version}-src</baseDirectory>
>    <fileSets>
>      <fileSet>
> -      <includes>
> -        <include>build-gump.xml</include>
> -        <include>build.xml</include>
> -        <include>doap_fileupload.rdf</include>
> -        <include>gump.xml</include>
> -        <include>LICENSE.txt</include>
> -        <include>NOTICE.txt</include>
> -        <include>pom.xml</include>
> -      </includes>
> -    </fileSet>
> -    <fileSet>
> -      <directory>src</directory>
> +      <directory>${basedir}</directory>
> +      <excludes>
> +        <exclude>**/.classpath</exclude>
> +        <exclude>**/.project</exclude>
> +        <exclude>**/.settings/</exclude>
> +        <exclude>**/bin/</exclude>
> +        <exclude>**/target/</exclude>
> +      </excludes>
>      </fileSet>
>    </fileSets>
>  </assembly>
>
>

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@commons.apache.org
For additional commands, e-mail: dev-help@commons.apache.org