You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by vanzin <gi...@git.apache.org> on 2018/01/04 19:04:05 UTC

[GitHub] spark pull request #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to ...

GitHub user vanzin opened a pull request:

    https://github.com/apache/spark/pull/20156

    [SPARK-22948][k8s] Move SparkPodInitContainer to correct package.

    

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/vanzin/spark SPARK-22948

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/20156.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #20156
    
----
commit a09a7287d9830a2fb7043717b31edad8a1574eae
Author: Marcelo Vanzin <va...@...>
Date:   2018-01-04T19:02:56Z

    [SPARK-22948][k8s] Move SparkPodInitContainer to correct package.

----


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20156
  
    **[Test build #85691 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85691/testReport)** for PR 20156 at commit [`a09a728`](https://github.com/apache/spark/commit/a09a7287d9830a2fb7043717b31edad8a1574eae).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to ...

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20156#discussion_r159751882
  
    --- Diff: dev/sparktestsupport/modules.py ---
    @@ -539,7 +539,7 @@ def __hash__(self):
     kubernetes = Module(
         name="kubernetes",
         dependencies=[],
    -    source_file_regexes=["resource-managers/kubernetes/core"],
    +    source_file_regexes=["resource-managers/kubernetes"],
    --- End diff --
    
    Otherwise when you change something outside of kubernetes/core (like the docker files), all unit tests will be run, not just the stuff related to k8s.
    
    I requested this change in the original PR but you guys never addressed it.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20156
  
    **[Test build #85692 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85692/testReport)** for PR 20156 at commit [`edc3e18`](https://github.com/apache/spark/commit/edc3e184f34c3b2c5f4646da637c9c03a0298b03).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/20156
  
    Merging to master / 2.3.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20156
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85692/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20156
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to ...

Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:

    https://github.com/apache/spark/pull/20156


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20156
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/85691/
    Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

Posted by liyinan926 <gi...@git.apache.org>.
Github user liyinan926 commented on the issue:

    https://github.com/apache/spark/pull/20156
  
    LGTM.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20156
  
    **[Test build #85691 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85691/testReport)** for PR 20156 at commit [`a09a728`](https://github.com/apache/spark/commit/a09a7287d9830a2fb7043717b31edad8a1574eae).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to ...

Posted by liyinan926 <gi...@git.apache.org>.
Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20156#discussion_r159751012
  
    --- Diff: dev/sparktestsupport/modules.py ---
    @@ -539,7 +539,7 @@ def __hash__(self):
     kubernetes = Module(
         name="kubernetes",
         dependencies=[],
    -    source_file_regexes=["resource-managers/kubernetes/core"],
    +    source_file_regexes=["resource-managers/kubernetes"],
    --- End diff --
    
    Why this change?


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

Posted by vanzin <gi...@git.apache.org>.
Github user vanzin commented on the issue:

    https://github.com/apache/spark/pull/20156
  
    @foxish @liyinan926 


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

Posted by SparkQA <gi...@git.apache.org>.
Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/20156
  
    **[Test build #85692 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/85692/testReport)** for PR 20156 at commit [`edc3e18`](https://github.com/apache/spark/commit/edc3e184f34c3b2c5f4646da637c9c03a0298b03).


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark pull request #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to ...

Posted by liyinan926 <gi...@git.apache.org>.
Github user liyinan926 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/20156#discussion_r159752504
  
    --- Diff: dev/sparktestsupport/modules.py ---
    @@ -539,7 +539,7 @@ def __hash__(self):
     kubernetes = Module(
         name="kubernetes",
         dependencies=[],
    -    source_file_regexes=["resource-managers/kubernetes/core"],
    +    source_file_regexes=["resource-managers/kubernetes"],
    --- End diff --
    
    Ah, sorry the comment was not caught by us.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org


[GitHub] spark issue #20156: [SPARK-22948][k8s] Move SparkPodInitContainer to correct...

Posted by AmplabJenkins <gi...@git.apache.org>.
Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/20156
  
    Merged build finished. Test PASSed.


---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org