You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Benno Evers <be...@mesosphere.com> on 2018/08/28 10:29:21 UTC
Review Request 68537: Cleaned up some style issues in
`ReadOnlyHandler`.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68537/
-----------------------------------------------------------
Review request for mesos and Alexander Rukletsov.
Repository: mesos
Description
-------
This commit fixes several minor style issues:
- Sorted member function declarations of `ReadOnlyHandler`
alphabetically.
- Added notes to remind readers of the fact that requests
to certain endpoints are batched.
- Changed captured variable in `/frameworks` endpoint handler.
Diffs
-----
src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005
src/master/readonly_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68537/diff/1/
Testing
-------
Thanks,
Benno Evers
Re: Review Request 68537: Cleaned up some style issues in
`ReadOnlyHandler`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68537/#review208027
-----------------------------------------------------------
FAIL: Some of the unit tests failed. Please check the relevant logs.
Reviews applied: `['68321', '68440', '68441', '68442', '68473', '68537']`
Failed command: `Start-MesosCITesting`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2248/mesos-review-68537
Relevant logs:
- [mesos-tests-cmake.log](http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2248/mesos-review-68537/logs/mesos-tests-cmake.log):
```
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\recordio.c(170): warning C4267: '=': conversion from 'size_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\mt_adaptor.c(496): warning C4244: '=': conversion from 'time_t' to 'int32_t', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(256): warning C4090: 'function': different 'const' qualifiers [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(166): warning C4716: 'pthread_cond_broadcast': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\winport.c(205): warning C4716: 'pthread_cond_wait': must return a value [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\zookeeper.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(124): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(128): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(279): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(301): warning C4267: 'initializing': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(368): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(372): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(512): warning C4267: 'function': conversion from 'size_t' to 'int', possible loss of data [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(543): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(548): warning C4996: 'fopen': This function or variable may be unsafe. Consider using fopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
d:\dcos\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8\src\c\src\cli.c(569): warning C4996: 'strcpy': This function or variable may be unsafe. Consider using strcpy_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8\src\zookeeper-3.4.8-build\cli.vcxproj] [D:\DCOS\mesos\3rdparty\zookeeper-3.4.8.vcxproj]
"D:\DCOS\mesos\src\tests\mesos-tests.vcxproj" (default target) (1) ->
"D:\DCOS\mesos\src\mesos.vcxproj" (default target) (18) ->
(ClCompile target) ->
d:\dcos\mesos\mesos\src\master\readonly_handler.cpp(649): error C3494: 'this' cannot be explicitly captured because an enclosing capture mode does not allow it [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\readonly_handler.cpp(651): error C3493: 'master' cannot be implicitly captured because no default capture mode has been specified [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\readonly_handler.cpp(667): error C3494: 'this' cannot be explicitly captured because an enclosing capture mode does not allow it [D:\DCOS\mesos\src\mesos.vcxproj]
d:\dcos\mesos\mesos\src\master\readonly_handler.cpp(669): error C3493: 'master' cannot be implicitly captured because no default capture mode has been specified [D:\DCOS\mesos\src\mesos.vcxproj]
172 Warning(s)
4 Error(s)
Time Elapsed 00:08:11.62
```
- Mesos Reviewbot Windows
On Aug. 28, 2018, 12:51 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68537/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2018, 12:51 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit fixes several minor style issues:
> - Sorted member function declarations of `ReadOnlyHandler`
> alphabetically.
> - Added notes to remind readers of the fact that requests
> to certain endpoints are batched.
> - Changed captured variable in `/frameworks` endpoint handler.
>
>
> Diffs
> -----
>
> src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005
> src/master/readonly_handler.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68537/diff/1/
>
>
> Testing
> -------
>
> Started Internal CI Run (Jenkins Id #4262)
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68537: Cleaned up some style issues in
`ReadOnlyHandler`.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68537/#review208046
-----------------------------------------------------------
PASS: Mesos patch 68537 was successfully built and tested.
Reviews applied: `['68321', '68440', '68441', '68442', '68473', '68537']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2249/mesos-review-68537
- Mesos Reviewbot Windows
On Aug. 28, 2018, 2:02 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68537/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2018, 2:02 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit fixes several minor style issues:
> - Sorted member function declarations of `ReadOnlyHandler`
> alphabetically.
> - Added notes to remind readers of the fact that requests
> to certain endpoints are batched.
> - Changed captured variable in `/frameworks` endpoint handler.
>
>
> Diffs
> -----
>
> src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005
> src/master/readonly_handler.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68537/diff/2/
>
>
> Testing
> -------
>
> Started Internal CI Run (Jenkins Id #4264)
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68537: Cleaned up some style issues in
`ReadOnlyHandler`.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68537/#review208065
-----------------------------------------------------------
Patch looks great!
Reviews applied: [68321, 68440, 68441, 68442, 68473, 68537]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On Aug. 28, 2018, 2:02 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68537/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2018, 2:02 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit fixes several minor style issues:
> - Sorted member function declarations of `ReadOnlyHandler`
> alphabetically.
> - Added notes to remind readers of the fact that requests
> to certain endpoints are batched.
> - Changed captured variable in `/frameworks` endpoint handler.
>
>
> Diffs
> -----
>
> src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005
> src/master/readonly_handler.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68537/diff/2/
>
>
> Testing
> -------
>
> Started Internal CI Run (Jenkins Id #4264)
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68537: Cleaned up some style issues in
`ReadOnlyHandler`.
Posted by Alexander Rukletsov <ru...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68537/#review208060
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Rukletsov
On Aug. 28, 2018, 2:02 p.m., Benno Evers wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/68537/
> -----------------------------------------------------------
>
> (Updated Aug. 28, 2018, 2:02 p.m.)
>
>
> Review request for mesos and Alexander Rukletsov.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This commit fixes several minor style issues:
> - Sorted member function declarations of `ReadOnlyHandler`
> alphabetically.
> - Added notes to remind readers of the fact that requests
> to certain endpoints are batched.
> - Changed captured variable in `/frameworks` endpoint handler.
>
>
> Diffs
> -----
>
> src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005
> src/master/readonly_handler.cpp PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/68537/diff/2/
>
>
> Testing
> -------
>
> Started Internal CI Run (Jenkins Id #4264)
>
>
> Thanks,
>
> Benno Evers
>
>
Re: Review Request 68537: Cleaned up some style issues in
`ReadOnlyHandler`.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68537/
-----------------------------------------------------------
(Updated Aug. 28, 2018, 2:02 p.m.)
Review request for mesos and Alexander Rukletsov.
Changes
-------
Fixed lambda capture list.
Repository: mesos
Description
-------
This commit fixes several minor style issues:
- Sorted member function declarations of `ReadOnlyHandler`
alphabetically.
- Added notes to remind readers of the fact that requests
to certain endpoints are batched.
- Changed captured variable in `/frameworks` endpoint handler.
Diffs (updated)
-----
src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005
src/master/readonly_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68537/diff/2/
Changes: https://reviews.apache.org/r/68537/diff/1-2/
Testing
-------
Started Internal CI Run (Jenkins Id #4262)
Thanks,
Benno Evers
Re: Review Request 68537: Cleaned up some style issues in
`ReadOnlyHandler`.
Posted by Benno Evers <be...@mesosphere.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/68537/
-----------------------------------------------------------
(Updated Aug. 28, 2018, 10:51 a.m.)
Review request for mesos and Alexander Rukletsov.
Changes
-------
Updated 'testing done' section.
Repository: mesos
Description
-------
This commit fixes several minor style issues:
- Sorted member function declarations of `ReadOnlyHandler`
alphabetically.
- Added notes to remind readers of the fact that requests
to certain endpoints are batched.
- Changed captured variable in `/frameworks` endpoint handler.
Diffs
-----
src/master/master.hpp 1e01dab8b5160e0b69670c896cb5e9fc0bf31005
src/master/readonly_handler.cpp PRE-CREATION
Diff: https://reviews.apache.org/r/68537/diff/1/
Testing (updated)
-------
Started Internal CI Run (Jenkins Id #4262)
Thanks,
Benno Evers