You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@dubbo.apache.org by li...@apache.org on 2021/02/23 16:37:19 UTC
[dubbo] branch master updated: refactoring (move method) to
AccessLogData class (#6151)
This is an automated email from the ASF dual-hosted git repository.
liujun pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/dubbo.git
The following commit(s) were added to refs/heads/master by this push:
new e28b228 refactoring (move method) to AccessLogData class (#6151)
e28b228 is described below
commit e28b228546d9ac311ee8e4f54acf8650454ef26c
Author: Kleber Tarcísio <kl...@yahoo.com.br>
AuthorDate: Tue Feb 23 13:37:06 2021 -0300
refactoring (move method) to AccessLogData class (#6151)
---
.../java/org/apache/dubbo/rpc/filter/AccessLogFilter.java | 15 ++-------------
.../java/org/apache/dubbo/rpc/support/AccessLogData.java | 15 +++++++++++++++
2 files changed, 17 insertions(+), 13 deletions(-)
diff --git a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java
index 63de8c4..e1c449f 100644
--- a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java
+++ b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/filter/AccessLogFilter.java
@@ -103,7 +103,8 @@ public class AccessLogFilter implements Filter {
try {
String accessLogKey = invoker.getUrl().getParameter(ACCESS_LOG_KEY);
if (ConfigUtils.isNotEmpty(accessLogKey)) {
- AccessLogData logData = buildAccessLogData(invoker, inv);
+ AccessLogData logData = AccessLogData.newLogData();
+ logData.buildAccessLogData(invoker, inv);
log(accessLogKey, logData);
}
} catch (Throwable t) {
@@ -166,18 +167,6 @@ public class AccessLogFilter implements Filter {
}
}
- private AccessLogData buildAccessLogData(Invoker<?> invoker, Invocation inv) {
- AccessLogData logData = AccessLogData.newLogData();
- logData.setServiceName(invoker.getInterface().getName());
- logData.setMethodName(inv.getMethodName());
- logData.setVersion(invoker.getUrl().getParameter(VERSION_KEY));
- logData.setGroup(invoker.getUrl().getParameter(GROUP_KEY));
- logData.setInvocationTime(new Date());
- logData.setTypes(inv.getParameterTypes());
- logData.setArguments(inv.getArguments());
- return logData;
- }
-
private void processWithServiceLogger(Set<AccessLogData> logSet) {
for (Iterator<AccessLogData> iterator = logSet.iterator();
iterator.hasNext();
diff --git a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/support/AccessLogData.java b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/support/AccessLogData.java
index e9ff358..ca2eac2 100644
--- a/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/support/AccessLogData.java
+++ b/dubbo-rpc/dubbo-rpc-api/src/main/java/org/apache/dubbo/rpc/support/AccessLogData.java
@@ -17,10 +17,15 @@
package org.apache.dubbo.rpc.support;
import org.apache.dubbo.common.utils.StringUtils;
+import org.apache.dubbo.rpc.Invocation;
+import org.apache.dubbo.rpc.Invoker;
import org.apache.dubbo.rpc.RpcContext;
import com.alibaba.fastjson.JSON;
+import static org.apache.dubbo.common.constants.CommonConstants.GROUP_KEY;
+import static org.apache.dubbo.common.constants.CommonConstants.VERSION_KEY;
+
import java.text.DateFormat;
import java.text.SimpleDateFormat;
import java.util.Arrays;
@@ -262,5 +267,15 @@ public final class AccessLogData {
private void set(String key, Object value) {
data.put(key, value);
}
+
+ public void buildAccessLogData(Invoker<?> invoker, Invocation inv) {
+ setServiceName(invoker.getInterface().getName());
+ setMethodName(inv.getMethodName());
+ setVersion(invoker.getUrl().getParameter(VERSION_KEY));
+ setGroup(invoker.getUrl().getParameter(GROUP_KEY));
+ setInvocationTime(new Date());
+ setTypes(inv.getParameterTypes());
+ setArguments(inv.getArguments());
+ }
}