You are viewing a plain text version of this content. The canonical link for it is here.

Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/11/04 16:38:51 UTC

[GitHub] [arrow] bkietz commented on pull request #8533: ARROW-10080: [R] Call gc() and try again in MemoryPool

bkietz commented on pull request #8533:
URL: https://github.com/apache/arrow/pull/8533#issuecomment-721841024


   @terencehonles Sorry for the breakage! I added this check when debugging injection of the customized memory pool. I didn't see that `PoolBuffer::MakeUnique()` coerces null `MemoryPool*` to `default_memory_pool()`, so I assumed leaving it in would be harmless. It can be removed, though it's still slightly suspicious to me that null would be passed for a memory pool given that the test logs seem to indicate a different memory manager (`allocation manager type not specified, using netty as the default type`) was selected.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org