[GitHub] [spark] gengliangwang commented on a diff in pull request #40449: [SPARK-42791][SQL] Create a new golden file test framework for analysis

["gengliangwang (via GitHub)" <gi...@apache.org>]

gengliangwang commented on code in PR #40449:
URL: https://github.com/apache/spark/pull/40449#discussion_r1139311712


##########
sql/core/src/test/scala/org/apache/spark/sql/QueryTest.scala:
##########
@@ -228,6 +229,101 @@ abstract class QueryTest extends PlanTest {
     assert(query.queryExecution.executedPlan.missingInput.isEmpty,
       s"The physical plan has missing inputs:\n${query.queryExecution.executedPlan}")
   }
+
+  /** A single SQL query's output. */
+  protected trait QueryTestOutput {

Review Comment:
   Now all the changes in `QueryTest` is only used in `SQLQueryTestSuite`. Shall we move these changes to `SQLQueryTestSuite`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org