You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/05/30 07:28:41 UTC

[GitHub] [incubator-linkis] CCweixiao opened a new issue, #2194: [Feature] [1.2.0] Cancel the supportedDBs in the jdbc engine ConnectionManager.java and add the parameter wds.linkis.jdbc.driver

CCweixiao opened a new issue, #2194:
URL: https://github.com/apache/incubator-linkis/issues/2194

   ### Search before asking
   
   - [X] I had searched in the [issues](https://github.com/apache/incubator-linkis/issues) and found no similar feature requirement.
   
   
   ### Problem Description
   
   _No response_
   
   ### Description
   
   如果新增一个jdbc数据源连接服务,需要修改参数wds.linkis.jdbc.support.dbs和wds.linkis.jdbc.support.dbs.validation.query,
   同时,引擎服务运行时会预先运行Class.forName(""),有些引擎,用户用不到时,没有放置驱动包,引擎启动就会有 driver class name找不到的异常信息输出,容易给用户造成困惑。
   同时增加wds.linkis.jdbc.driver 参数,取消了supportDbs的限制,提高了jdbc数据源连接配置的灵活性,同时参数wds.linkis.jdbc.support.dbs.validation.query 其实属于数据库连接池参数,应该提出来与url username等参数一起维护配置。
   
   If you add a jdbc data source connection service, you need to modify the parameters wds.linkis.jdbc.support.dbs and wds.linkis.jdbc.support.dbs.validation.query,
   At the same time, when the engine service is running, Class.forName("") will be run in advance. For some engines, when the user does not use it, the driver package is not placed. When the engine starts, there will be abnormal information output that the driver class name cannot be found, which is easy to give to the user. cause confusion.
   At the same time, the wds.linkis.jdbc.driver parameter is added, which cancels the limitation of supportDbs and improves the flexibility of jdbc data source connection configuration. At the same time, the parameter wds.linkis.jdbc.support.dbs.validation.query actually belongs to the database connection pool parameter. Should be brought up to maintain the configuration along with parameters like url username etc.
   
   ### Use case
   
   _No response_
   
   ### solutions
   
   1.  取消参数wds.linkis.jdbc.support.dbs和wds.linkis.jdbc.support.dbs.validation.query
   2. 与wds.linkis.jdbc.connect.url等基础参数类似,增加参数wds.linkis.jdbc.driver,给用户更灵活的配置方式
   
   ### Anything else
   
   _No response_
   
   ### Are you willing to submit a PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org


[GitHub] [incubator-linkis] CCweixiao closed issue #2194: [Feature] [1.2.0] Cancel the supportedDBs in the jdbc engine ConnectionManager.java and add the parameter wds.linkis.jdbc.driver

Posted by GitBox <gi...@apache.org>.
CCweixiao closed issue #2194: [Feature] [1.2.0] Cancel the supportedDBs in the jdbc engine ConnectionManager.java and add the parameter wds.linkis.jdbc.driver
URL: https://github.com/apache/incubator-linkis/issues/2194


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org