You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2020/06/10 01:59:30 UTC

[GitHub] [pulsar] zhanghaou commented on a change in pull request #7222: Fix bug related to managedLedger properties

zhanghaou commented on a change in pull request #7222:
URL: https://github.com/apache/pulsar/pull/7222#discussion_r437817354



##########
File path: managed-ledger/src/main/java/org/apache/bookkeeper/mledger/impl/ManagedLedgerImpl.java
##########
@@ -3245,14 +3243,19 @@ public void setPropertiesFailed(ManagedLedgerException exception, Object ctx) {
     }
 
     @Override
-    public void asyncSetProperties(Map<String, String> properties, final SetPropertiesCallback callback, Object ctx) {
+    public void asyncSetProperties(Map<String, String> properties, boolean isOverwrite,
+                                   final SetPropertiesCallback callback,
+                                   Object ctx) {
+        propertiesMutex.lock();

Review comment:
       OK. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org