You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@tinkerpop.apache.org by "spmallette (GitHub)" <gi...@apache.org> on 2020/04/02 13:35:23 UTC

[GitHub] [tinkerpop] spmallette commented on issue #1275: gremlin-javascript: remove session close method

> o... but PRs for .Net SDK on 3.4-dev removed "close" request

i must have missed that in review :( i thought that #1263 only resolved conflicts in `3.4-dev` and made sure everything worked given this comment from @FlorianHockmann :

https://github.com/apache/tinkerpop/pull/1257#issuecomment-595763604

@heljoyLiu i think you follow what needs to happen now. do not worry about `master`. if you could please make sure that `3.3-dev` and `3.4-dev` send the "close" message for all languages and that the "close" message does not have the "gremlin" argument. let's get that much correct before we worry about anything else. thank you.

[ Full content available at: https://github.com/apache/tinkerpop/pull/1275 ]
This message was relayed via gitbox.apache.org for dev@tinkerpop.apache.org